careerfoundry/cf_shop

Demo Application for CareerFoundry Rails Course

cf_shop's Issues

Replace Controller Tests with Feature Tests

I'm a graduate of the CareerFoundry course. The course was a huge help and as a Rails Developer I use almost everything I learned on the job, except for controller testing.

Controller testing as a whole is deprecated within the Rails community. They should be replaced with feature tests (as suggested by this article) which would better prepare CF grads for employment.

comments layout issue <div> inside <p> in products/show.html.erb

In case anyone else is having trouble figuring out why their comments aren't showing properly. This may be the problem. In app/views/products/show.html.erb in the line starting with Average Rating: there is a div inside a p element. If the div is changed to a span element, the p element will then close properly. The p element breaks at the opening of the div element thus causing layout chaos, but changing div to span solves this problem.