carm1r/fruclimadapt

Evaluation tools for assessing climate adaptation of fruit tree species

fruclimadapt's Issues

Please import only the functions you use from data.table

hi @Carm1r
There are several instances of @import data.table in your roxygen comments, which get converted to import(data.table) in your NAMESPACE, which has the effect of importing everything that data.table exports.
In the new version of data.table on github master, remotes::install_github("Rdatatable/data.table") there are new exported objects yearmon and yearqtr.
There are also exported objects with these same two names in package zoo which you also import.
This has the effect of generating the following new warning when I run R CMD check fruclimadapt with data.table github master installed:

* checking whether package 'fruclimadapt' can be installed ... WARNING
Found the following significant warnings:
  Warning: replacing previous import 'data.table::yearmon' by 'zoo::yearmon' when loading 'fruclimadapt'
  Warning: replacing previous import 'data.table::yearqtr' by 'zoo::yearqtr' when loading 'fruclimadapt'

The fix would be to use @importFrom data.table setDT etc (for only the objects you use), instead of @import data.table.
Please update your code, then run R CMD check fruclimadapt_vers.tar.gz with data.table master installed.
After you update your code and R CMD check has no more errors, please submit a new version of fruclimadapt to CRAN.
This will help facilitate releasing a new version of data.table to CRAN.
(data.table devs must make sure all reverse dependencies do not break, before submitting a new version to CRAN)