carrot-garden/carrot-maven

various maven related projects

info

various Maven related projects

site

maven info sites

carrot-maven-aws-plugin

carrot-maven-scr-plugin

carrot-maven's Issues

Error when building large project tree

Caused by: java.util.ConcurrentModificationException
at java.util.ArrayList$Itr.checkForComodification(ArrayList.java:819)
at java.util.ArrayList$Itr.next(ArrayList.java:791)
at com.carrotgarden.maven.scr.CarrotOsgiScrGenerate.includeDescriptorResource(CarrotOsgiScrGenerate.java:159)
at com.carrotgarden.maven.scr.CarrotOsgiScrGenerate.execute(CarrotOsgiScrGenerate.java:114)
... 21 more

When running "mvn -DskipTests=true install" on barchart-news.

com.carrotgarden.base:carrot-maven-aws-plugin-test-image-build:1.1.0-SNAPSHOT fails on windows machines

When run on windows the regex on the path fails when it encounters a '' in the path, unaviodable on a windows machine.

Caused by: java.util.regex.PatternSyntaxException: Unknown character property name {4} near index 4
C:\p4\formsetwork\sdtax\bui\maven2\AMIBuilder\carrot-maven-aws-plugin-test-image-build\target\publish
^
at java.util.regex.Pattern.error(Pattern.java:1713)
at java.util.regex.Pattern.charPropertyNodeFor(Pattern.java:2437)
at java.util.regex.Pattern.family(Pattern.java:2412)
at java.util.regex.Pattern.sequence(Pattern.java:1831)
at java.util.regex.Pattern.expr(Pattern.java:1752)
at java.util.regex.Pattern.compile(Pattern.java:1460)
at java.util.regex.Pattern.(Pattern.java:1133)
at java.util.regex.Pattern.compile(Pattern.java:823)
at java.lang.String.replaceFirst(String.java:2146)
at com.carrotgarden.maven.aws.ssh.PathMaker.getEntryList(PathMaker.java:87)
at com.carrotgarden.maven.aws.ssh.SecureShell.publish(SecureShell.java:210)
at com.carrotgarden.maven.aws.ssh.CarrotAwsSecuShelPublish.execute(CarrotAwsSecuShelPublish.java:62)
... 21 more

Add Capability support to AWS CloudFormation plugin

When creating stacks involving IAM, it's required to include IAM capability in the request. Request will look like following, note Capabilities.member.1=CAPABILITY_IAM :

https://cloudformation.us-east-1.amazonaws.com/
  ?Action=CreateStack
  &StackName=MyStack
  &TemplateBody=[Template Document]
  &Capabilities.member.1=CAPABILITY_IAM
  &...

It would be good to have configuration parameter capabilities:

<configuration>
   ...
   <capabilities>CAPABILITY_IAM</capabilities>
   ...
</configuration>

See:
http://docs.aws.amazon.com/AWSCloudFormation/latest/APIReference/API_CreateStack.html

PS: Same applies to NotificationARNs.member.N, but it's not used in my case.

Service provided when not requested

For a component with an empty service attribute,

@Component(name = "Foo", service = {})
public class Foo implements Bar {
}

the generated descriptor still contains a service when it shouldn't:

<service>
  <provide interface="com.acme.Bar"/>
</service>

package-info.java

need special handling of package-info.java and such

carrot-maven-scr-plugin only works with patched version of annotations

I tried combining this plugin with tycho. Everything works fine also in eclipse using the m2e configurator, but I noticed that when I use the original OSGi service annotations, generation will not recognize any annotated classes.

This is because the original OSGi annotations have been patched (or the version is outdated) to use

@retention(RetentionPolicy.RUNTIME)

instead of

@retention(RetentionPolicy.CLASS)

Unfortunately the plugin does its annotation scan using a classloader which only works if annotations are preserved at runtime. Instead of a classloader, I suppose a bytcode library such as e.g. ASM could be used to do the annotation scanning instead.

See tycho enhancement request https://bugs.eclipse.org/bugs/show_bug.cgi?id=392764