carstenschaefer/gulp-delete-lines

A gulp plugin that will remove all lines that matches one of the given regex filters.

gulp-delete-lines's Issues

Bug creating douplicating lines if several filters are set

Hey,

it seems like your code has a major bug producing douplicates of valid lines of more than one filter is set:

     for (_j = 0; _j < opt.filters.length; _j++) {
        if (! lines[_i].match(opt.filters[_j])) {
            newLines.push(lines[_i]);
        }
      }

In the inner for loop you have to check if the line was already added or if better would be to add it in the first place and remove it if one of the filters match.
If you don't do this the line will be added for every filter that doesn't match.

Greetz

David

remove gulp-util

https://medium.com/gulpjs/gulp-util-ca3b1f9f9ac5

remove gulp-util using the following API replacements:

gutil.File => https://www.npmjs.com/package/vinyl
gutil.replaceExtension => The .extname property on Vinyl objects or https://www.npmjs.com/package/replace-ext
gutil.colors => https://www.npmjs.com/package/ansi-colors
gutil.date => https://www.npmjs.com/package/date-format
gutil.log => https://www.npmjs.com/package/fancy-log
gutil.template => https://www.npmjs.com/package/lodash.template
gutil.env => https://www.npmjs.com/package/minimist
gutil.beep => https://www.npmjs.com/package/beeper
gutil.noop => https://www.npmjs.com/package/through2
gutil.isStream => Use the .isStream() method on Vinyl objects
gutil.isBuffer => Use the .isBuffer() method on Vinyl objects
gutil.isNull => Use the .isNull() method on Vinyl objects
gutil.linefeed => Use the string '\n' in your code
gutil.combine => https://www.npmjs.com/package/multipipe
gutil.buffer => https://www.npmjs.com/package/list-stream
gutil.PluginError => https://www.npmjs.com/package/plugin-error

Is there a way to remove certain lines from a file by relative position?

For example, is there an easy way to remove the last 10 lines from a file?

Choosing multiple regex in the filters array not working

Hello,

Below is a code of how I've currently setup this function. For some reason on compilation the lines aren't being removed.

// ...
.pipe(deleteLines({
    'filters': [
        /<base\s+href=["']/i,
        /<script\s+src=["']https:\/\/ajax\.googleapis\.com\/ajax\/libs\/jquery\/1\.12\.2\/jquery\.min\.js["']/i
    ]
}))
// ...

However, when I reduce the array to 1 item like below, it works.

// ...
.pipe(deleteLines({
    'filters': [
        /<base\s+href=["']/i
    ]
}))
// ...