Comments (4)
The options for the rule look fine. There is no real recommendation regarding those. However, if you are using the Angular CLI you should follow the configuration recommendations in the README or look at what was done in the included example.
My figuring out what's happening is close to impossible, but I do have some questions that you can ask yourself and investigate:
- If you are using the Angular CLI, have you ejected? Have you changed the linting configuration at all?
- The Angular linting runs in three passes. Which fails? Do any succeed?
- Moving the files around should not be a problem. I have CLI projects with a structure similar to what you've outlined. Was anything else changed when it was restructured?
- Are you sure all of the files are being linted? If a file is not linted, its usage of a patching observable or operator will not count and said patching could be reported as unused. To ensure the files you expect to be linted are so, why not add some code to intentionally fail the linting?
- Is it only
fromEvent
? Have you changed the code to usefromEvent
as an imported function, rather than a patching observable?
Hope that's helpful.
from rxjs-tslint-rules.
I think my issue is similar to #33
I saw what you wrote on that Issue and I've tried the following:
In my auth.service.ts
, I have this line:
const foo = Observable.of([]);
This gets rid of the ERROR: ../client/src/rxjs.imports.ts[8, 1]: Unused patched observable in ./src/rxjs.imports.ts: of
Any ideas why the linter isn't picking up the usage in the actual class?
This isn't really a big deal, imo. Just a nice to fix, fix.
from rxjs-tslint-rules.
The problem is that it's very difficult to see the whole context. I'm not even sure what the class you mention looks like or what the usage of Observable.of
is like within it.
Basically, the three-pass linting that's in the CLI makes dealing with a single imports file a little tricky - doable, but somewhat tricky. However, it makes diagnosing problems almost impossible. I think that the only way these sorts of things could be addressable would be if the problem could be reproduced - in a fork - using the CLI example that's in this repo.
All I can suggest - without a repro - is that you do what's mentioned in the README:
- switch of the unused rule for the e2e tests; and
- make sure all of the RxJS imports in the single import file are used in both the tests and the app.
from rxjs-tslint-rules.
Closing this, as without a repro, there's not much I can do.
However, I realise that I didn't ask whether or not you were using TSLint's no-unused-variable
rule. I've since added an issue template with the following note:
Please ensure that TSLint's
no-unused-variable
rule is not enabled in your configuration (or in any configuration that you extend). That rule has caused problems in the past - as it leaves the TypeScript program in an unstable state - and has a significant number of still-open issues.
from rxjs-tslint-rules.
Related Issues (20)
- False positive for rxjs-no-unsafe-scope on parameter type HOT 1
- ESLint port? HOT 1
- rxjs-no-ignored-observable not working? HOT 1
- rxjs-no-compat not detecting rxjs-compat import for Observable.of HOT 7
- rxjs-no-create is not working without type information HOT 4
- rxjs-no-redundant-notify is too simplistic HOT 4
- Deprecated rules? HOT 3
- Changlog has incorrectly named rules. HOT 1
- Whitelist class property in rxjs-finnish based on decorator HOT 3
- Support for untilDestroyed alias in rxjs-no-unsafe-takeuntil HOT 8
- Support for class inheritance on rxjs-prefer-angular-takeuntil HOT 3
- Subscribing without takeUntil is forbidden (rxjs-prefer-angular-takeuntil) when take(1) is added HOT 1
- Not so opinionated analog of `rxjs-prefer-angular-takeuntil`, please HOT 9
- Allow DOMExceptions with rxjs-throw-error HOT 2
- Feature Request > Remove RxJS as a Peer Dependency HOT 3
- False positive prefer-angular-composition with unsubscribe in super class HOT 1
- [Request] rxjs-prefer-angular-composition for services. HOT 2
- rxjs-prefer-angular-takeuntil doesn't work with param "this" HOT 1
- [Request] Define a new rule to enforce to have catchError operator HOT 2
- shareReplay is forbidden unless a config argument is passed
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rxjs-tslint-rules.