`rxjs-no-unsafe-takeuntil` doesn't work for all cases.

[cartant]

`rxjs-no-unsafe-takeuntil` doesn't work for all cases.

[cartant]

It won't check functions that are passed to the operator by name. Basically, doing so would quickly make the static analysis much harder.

Also, I'd suggest that passing a function that's accessed via this and is unbound is itself potentially unsafe an is deserving of its own rule. The this context is lost, so if you are going to do that, it should really be a static function or a function that's not at all tied to the class.

[cartant]

I really shouldn't comment on anything until I've had my morning coffee. The rule is positional, so it should be a bug.

[cartant]

Thanks for opening the issue. I've created a fixture for a repro and it appears that the rule has a problem with the pipe being appended to the fromEventPattern call. If the two are separated, the rule works as expected:

    const temp = fromEventPattern<MediaQueryList>(
      (listener: Function) => { mql.addListener((e: MediaQueryList) => listener(e)); },
      (listener: Function) => { mql.removeListener((e: MediaQueryList) => listener(e)); }
    );
    const queryObservable = temp.pipe(
      takeUntil(this._destroy),
      startWith(mql),
      map((nextMql: MediaQueryList) => ({ matches: nextMql.matches }))
    );

Should be pretty easy to fix. I hope.

[cartant]

This should be fixed in 4.4.2. As always, it was a copy-paste-related bug.