Comments (3)
This means that the factories would be public API which is never a good thing. I explain the motivation in this talk: https://jakewharton.com/helping-dagger-help-you/. It's a design decision not to do this, and if you want this behavior you might want to use AutoFactory instead.
from inflationinject.
Sorry, I don't understand what you mean specifically by the factory being public API here (are you referring to the implementation or interface here)? Aren't the interfaces already public APIs?
Were you referring to the fact that they'd be generated and the compilation issues that accompany that (re:AutoFactory)?
from inflationinject.
Yes, the generated factories. It violates the whole principle that Dagger, Auto, etc. preach which is that the exposed API is always hand-written and the libraries generate the implementation. This library subscribes to that philosophy, and AutoFactory, weirdly, does not (at least not by default).
from inflationinject.
Related Issues (20)
- The generated module should be annotated with `@DisableInstallInCheck` HOT 1
- Factory in viewmodel using hilt @ViewModelInject needs fully qualified class name HOT 4
- @DisableInstallInCheck for generated modules ( Hilt ) HOT 2
- @AssistedModule's @Module must include AssistedInject_AssistedModule HOT 3
- AssistedFactory_Factory not regenerated after the files it references are deleted HOT 2
- AssistedInject in Android UI tests HOT 1
- Carry annotations from interface into generated implementation HOT 6
- error: @AssistedModule's @Module must not include HOT 1
- Factory method parameters do not match constructor @Assisted parameters. Both parameter type and name must match. HOT 1
- Deprecate use with dagger 2 HOT 1
- @dagger.Module(includes = {AssistedInject_SampleAssistedInjectModule.class})
- Runtime gets Kotlin stdlib added despite being written in Java
- Port Turbine's release infra
- KSP Support HOT 6
- InflationInject throws error when a custom view is a kotlin class with @JvmOverloads marked constructor HOT 5
- InflationInjectionModule should generate module entries in a stable order to prevent Gradle cache misses
- LD
- Dependency Dashboard
- Get the Gradle wrapper validation action out of the critical path
- LD
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from inflationinject.