Generation fails when Factory method is in base interface and uses generics

[cashapp]

Generation fails when Factory method is in base interface and uses generics

[JakeWharton]

Er, are you sure this is silent? When I wrote the test it failed with an error that the interface was empty.

[gabrielittner]

Checked again and there was an error from AssistedInject. Maybe I've just missed it among all the Dagger errors the last time.

[JakeWharton]

Great. I just realized I made the fix without generics so I'll have to write another test case for that.

…

On Mon, Nov 12, 2018, 5:27 AM Gabriel Ittner ***@***.*** wrote: Checked again and there was an error from AssistedInject. Maybe I've just missed it among all the Dagger errors the last time. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#73 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEEEdDZPYZQIMWXqQv3Jb0eYeh8uRjbks5uuU0WgaJpZM4YUPyN> .

[JakeWharton]

Re-opening for generics. Feel free to try the SNAPSHOT in the mean time and see if it works.

[gabrielittner]

I've got generics in my usage. Not sure if auto-common has something to help resolving generic types, but I've written something to resolve generic return types of inherited methods two years ago. Maybe it helps. https://github.com/gabrielittner/auto-value-extension-util/blob/master/auto-value-extension-util/src/main/java/com/gabrielittner/auto/value/util/ElementUtil.java#L152-L239 Tests https://github.com/gabrielittner/auto-value-extension-util/blob/master/auto-value-extension-util/src/test/java/com.gabrielittner.auto.value.util/ElementUtilTest.java#L338-L445

…

On Wed, 14 Nov 2018 at 00:44, Jake Wharton ***@***.***> wrote: Re-opening for generics. Feel free to try the SNAPSHOT in the mean time and see if it works. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#73 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABS5GU6qH7rR4-5t0zSsu6MIPvFhiiWuks5uu1lPgaJpZM4YUPyN> .

[JakeWharton]

I know you have generics which is why I mentioned it. Does that mean you tried the snapshot and it doesn't work?

[gabrielittner]

Yeah I'm getting

/Users/gabriel/.../SearchBinder_AssistedFactory.java:26: error: cannot find symbol
  public BaseBinder<S, E> create(View view) {
                    ^
  symbol:   class S
  location: class SearchBinder_AssistedFactory

/Users/gabriel/....w/SearchBinder_AssistedFactory.java:26: error: cannot find symbol
  public BaseBinder<S, E> create(View view) {
                       ^
  symbol:   class E
  location: class SearchBinder_AssistedFactory

[gabrielittner]

Works perfectly now 👍 Thanks