Infinite loop and RAM exhaustion when attempting to split vehicle

[olanti-p]

Infinite loop and RAM exhaustion when attempting to split vehicle

[olanti-p]

Looks like when the vehicle parts are erased by it = parts.erase( it ) here

Cataclysm-BN/src/vehicle.cpp

Lines 1966 to 1979 in d82fd66

	for( std::vector<vehicle_part>::iterator it = parts.begin(); it != parts.end(); /* noop */ ) {
	if( it->removed ) {
	auto items = get_items( std::distance( parts.begin(), it ) );
	while( !items.empty() ) {
	items.erase( items.begin() );
	}
	const tripoint &pt = global_part_pos3( *it );
	here.clear_vehicle_point_from_cache( this, pt );
	it = parts.erase( it );
	changed = true;
	} else {
	++it;
	}
	}

parts, which is of type std::vector<vehicle_part>, reallocates the vehicle parts by copying them like this:

Cataclysm-BN/src/vehicle_part.cpp

Lines 109 to 117 in d82fd66

	vehicle_part &vehicle_part::operator=( const vehicle_part &source )
	{
	copy_static_from( source );
	base = item::spawn( *source.base );
	for( item * const &it : source.items ) {
	items.push_back( item::spawn( *it ) );
	}
	return *this;
	}

Which ends up spawning extra items.