catholicon/offlineqr

Offline QR code generator

offlineqr's Issues

Add-On does not open correctly in FF 30.0

I just installed this add-on in Firefox 30.0. When I try to open it, the app only opens as a small white box in the middle of my screen. Please see the attachment.

Please make a real release for ff56 users

Hi

The addon page turns almost empty, I am not sure. Can you please make a release here on GH for those of us who use stuff like Waterfox (FF56)?

thansk

Javascript error in Firefox 15

Error: Exposing chrome JS objects to content without exposedProps is insecure and deprecated. See https://developer.mozilla.org/en/XPConnect_wrappers for more information.
Source File: javascript:self.on("click", function (junk) {self.postMessage("junk");});

keyboard shortcut

OfflineQR use alt+shift+q as keyboard short cut.
this shortcut is used to type char on mac os.

never use "shift", "ctrl+shift" (="AltGr" on win) or "alt+shift" modifier for keyboard short cut.

Add license file

It would be good if you could add a license file to this repo.

Obviously you also have to look for the licenses of the scripts you included and add the licenses too.

Eg. CC-BY used here, the MIT license used by bootstrap and so on.
Also check that all licenses are compatible and all contributors have to accept that their code will be published under this license...

Please add ability to remove context menu option

As a responsible add-on developer please add option to remove "show QR" from context menu. All add-ons should let you do it so you can prevent Firefox context menu become all messy. The button on the add-on bar suffices.

Firefox 20.0.1 problem (small not proportional window with a hidden QR code)

Hello,

Windows XP 32bit + Firefox 20.0.1 -> "Show QR"by right mouse click -> small window (high height and small width) where QR code is not visible.
Options are default
Please help! :)
Thanks for nice Add-on!

please increase Block size in pixels limit to 25 or even more

reason: I am using a hi res monitor and also want to be able read
the QR code from some distance.

Many thanks for this really nice add-on!
-k

QR code should be shown in private browsing mode too

Hope have save image function...

Hope have save image function...
Thank you :-(

Context menu entries missing

After updating to the new version (0.9.4), which is great BTW, I was astounded to find that the QR entries in the context menu were missing, regardless whether I was clicking on a link, image, selection or simply on the page.
The error in the console states:

Tue May 14 2013 12:47:49
Error: offline_qr: An exception occurred.
TypeError: this.separator is null
resource://jid1-5h9we5dytuz14q-at-jetpack/addon-sdk/lib/sdk/context-menu.js 771
Traceback (most recent call last):
File "resource://jid1-5h9we5dytuz14q-at-jetpack/addon-sdk/lib/sdk/context-menu.js", line 945, in updateItemVisibilities
this.populate(this.items);
File "resource://jid1-5h9we5dytuz14q-at-jetpack/addon-sdk/lib/sdk/context-menu.js", line 715, in populate
this.createItem(item, after);
File "resource://jid1-5h9we5dytuz14q-at-jetpack/addon-sdk/lib/sdk/context-menu.js", line 838, in createItem
this.insertIntoXUL(item, xulNode, after);
File "resource://jid1-5h9we5dytuz14q-at-jetpack/addon-sdk/lib/sdk/context-menu.js", line 771, in insertIntoXUL
before = this.separator.nextSibling;

After half an hour search I noticed that there is a conflict with the Menu Editor extension that I have been using a long time now. When I disabled it, the context menu entry appeared normally.

Since the Menu Editor's development seems to have been abandoned since 2011, it is most possible it is to blame for not keeping up with Firefox, but could you check if there is a possibility that Offline QR generator caused the problem? And whether it can be worked around from your side?

Thanks in advance for your answer,
Giovanni

"QR for selected text" missing

Firefox version 44.0a2 (2015-12-01), currently in Aurora channel

To reproduce: highlight text. Right click / press Alt + Shift + Q.

Expected result: the context menu offers "Show QR for the selected text" / a QR code for the highlighted text is generated.

Actually: the option is missing from the context menu / the shortcut generates a QR code for the current page's URL.

QR out of screen bounds

I sometimes have the issue that the QR code does not completely lie in the visible screen area. Could you add the possibility to move the QR code display (e.g. by dragging it with the mouse)?

Movable QR code "popup"

It would be nice if you could somehow drag and drop the QR code "popup" on the site.
E.g. just move it to another place, because you want to read the text behind it or - if you have a huge (4K) screen or multiple ones - you may move it to a place where you can better scan it.

Character set and count?

Thank you for this plugin, I really like it and use it often. Sorry for asking, but I could not find this information elsewhere and I would really appreciate your help. I have seen the table about the capacity

I would like to know the capacity in characters, which probably depends on the character set. So I would like to know the character set. Are you performing detection of this? If that is the case, some letters could take one byte, but then take several when other letter in a different character set is introduced. E.g. writing kanji, then add a character like 'ç'.

I think kanji takes 1 byte per character, does that mean a total of 256 kanjis are supported? Is there any place where I can find a table of characters and the bytes needed to encode them?

Thank you for your help.

Don't work correctly with UTF-8 coding

Only latin1 subset of characters decoded.
For example russian text as "привет" decoded as "?@825B" at Android phones (QR Droid program)

WebExtensions are the future!

Edit: Below you can find a proper replacement for this add-on!

The current plan is that Firefox 57 will only support web extensions. Your add-on is not a web extension yet as far as I can see, so you should consider remaking your add-on. The Firefox 57 release is planned for 28th November 2017.
Already since Firefox 53 (planned release: 18th April 2017) AMO (addons.mozilla.org) no longer accept other new add-on submissions than web extensions. Old extensions can however still be updated.
The good message is that one should be able to use your web extensions add-on in all mayor browsers. That's the idea behind web extensions.
Note that you can use so-called hybrid extensions for switching to WebExtensions.

Note that all dates are estimates and may be changed.

German source: https://www.soeren-hentzschel.at/firefox/firefox-57-mit-exklusiver-webextension-unterstuetzung/
Original source: https://blog.mozilla.org/addons/2016/11/23/add-ons-in-2017/

QR generator maybe create to Clipboard？

QR generator maybe create to Clipboard？
thanks，QR generator is Great Add-on for firefox.

Save QR codes with transparent background

Would be nice if you could be able to save the QR code with a transparent background. As you already use PNG this is possible.

Make the icon more Australis-like

It would be nice if the toolbar icon could be more "Australis-like". It is near the Australis style as it is only in grey style, but it's still black/transparent.

To really fit into the style of the default Firefox tool buttons the icon should use the same grey color as the default ones instead of the #000000 black.

QR code quality low when saved as file

When you save the QR code as a file with the built-in function and zoom into it you see that the quality of the image is quite low:

It is not a real black/white.

However if you just screenshot the QR code showed when displaying it, it looks much better.

You may consider even reducing the size of the saved image and save it with a low color depth and if you use only 2bits (in case this is possible) this would also fix this problem. 😃

Related: #23

icon placement

when I move the icon from addon bar to navigation toolbar, it always move back to addon bar on firefox restart.

(In the next firefox version, addon bar will be removed.)

Visible resizing after different long QR codes

Have a look at this gif:

As you can see when I select the second small text ("javascript") you can see for a short time the previous bigger QR code and see that it resizes.
I think this is a kind of visually issue. 😉

Not compatible with e10s

Is this add-on compatible with Electrolysis (e10s)? Electrolysis is the new architecture of Firefox and Mozilla already rolls out some stable Firefox versions with e10s enabled.

More information:

• https://arewee10syet.com/
• https://wiki.mozilla.org/Electrolysis

---

According to ACR this add-on is not compatible with e10s.

Menu Wizard: Icon not hideable

With Menu Wizard I cannot hide the context menu entry:

I know there is an option in the settings to change this, but it is nicer to be able to use your own way to do this if you want.

Option required to have QR code generated for page background image too

QR generator maybe scan QR

QR generator maybe scan QR，

QR menu entry does not appear when in popup window

only in a browser tab.
As a (hopefully temporary) workaround I have to set
browser.link.open_newwindow.restriction to zero so a popup window
will open a new tab and in this new tab QR menu works OK.
This seems to be an addon-sdk feature (limitation)... clever
workaround wanted.
Best regards