ceekaybee/tennis-refactoring-kata-java

My solution to the Tennis Refactoring Kata (Java)

A few notes

• I have only completed the TennisGame1 refactoring so far
• I tried to refactor using Object Calisthenics guidelines, however I could not remove all the setters and getters (especially calls to player.getScore())
• The requirements and starting code are from https://github.com/emilybache/Tennis-Refactoring-Kata

Tennis Kata

Tennis has a rather quirky scoring system, and to newcomers it can be a little difficult to keep track of. The tennis society has contracted you to build a scoreboard to display the current score during tennis games.

Your task is to write a “TennisGame” class containing the logic which outputs the correct score as a string for display on the scoreboard. When a player scores a point, it triggers a method to be called on your class letting you know who scored the point. Later, you will get a call “score()” from the scoreboard asking what it should display. This method should return a string with the current score.

You can read more about Tennis scores here which is summarized below:

1. A game is won by the first player to have won at least four points in total and at least two points more than the opponent.
2. The running score of each game is described in a manner peculiar to tennis: scores from zero to three points are described as "Love", "Fifteen", "Thirty", and "Forty" respectively.
3. If at least three points have been scored by each player, and the scores are equal, the score is "Deuce".
4. If at least three points have been scored by each side and a player has one more point than his opponent, the score of the game is "Advantage" for the player in the lead.

You need only report the score for the current game. Sets and Matches are out of scope.

Questions to discuss afterwards

• How did it feel to work with such fast, comprehensive tests?
• Did you make mistakes while refactoring that were caught by the tests?
• If you used a tool to record your test runs, review it. Could you have taken smaller steps? Made fewer refactoring mistakes?
• Did you ever make any refactoring mistakes and then back out your changes? How did it feel to throw away code?
• What would you say to your colleague if they had written this code?
• What would you say to your boss about the value of this refactoring work? Was there more reason to do it over and above the extra billable hour or so?