centerforopenscience/ember-osf-web

Ember front-end for the Open Science Framework

ember-osf-web's Issues

Rendering of markdown files in Viewer

Hello, apologies if I have this wrong as this is my first time opening an issue!

I have a repository with the OSF where inside we have linked out each of the project modules to separate GitHub repositories with markdown files containing a list of instructions (example).

Unfortunately, when these files are viewed though the OSF website, it renders incorrectly with the images missing.

I understand that as these modules are not directly hosted on the OSF it may be difficult/impossible to render these markdown files correctly. Is there any possibility to get this fixed?

Thank you 😊

ember-changeset

Explore using ember-changeset (along with ember-changeset-cp-validations).

Upgrade to [email protected] and use bundled decorators.

Once salsify/ember-css-modules#118 gets merged and released.

hide payload warnings

embermap/ember-data-storefront#24

Set async=false for all relationships.

We should set async=false for all relationships (see reference below). Since we are using decorators, an easy way would be just to define custom @hasMany and @belongsTo decorators that do this by default and import them in place of the ember-decorators decorators.

Having a guarantee that writing post.get('comments') in JavaScript or {{post.comments.length}} in Handlebars won't trigger any side effects is a big benefit for developers – synchronous templates and computed properties are straightforward and predictable. And if they do forget to load something, instead of having the template's rendering pass try to do it for them, the developer would just see missing data and go load it explicitly themselves somewhere, perhaps in a route or a component hook using an Ember Concurrency task.

Reference: https://embermap.com/notes/83-the-case-against-async-relationships