centerhighperformancebuildingspurdue/achp

A python-based air conditioning and heat pump system model

achp's Issues

something about the accuracy of heat exchanger model

Hi,Bahman!As I said,the multi row HX model can be divided into several single row HX models in series.With this method,it can simulate both parallel and counter flow HX. Maybe you can try it.

PHEHX calculation

Hello,

I tried to calculate with the PHEHX module and found out a potential copy-paste-error in the code:
line 1273: if Tin_h != Tout_c:
I think it should be "if Tin_h != Tout_h" (which checks if there is a glide)
Could you please check it? Thank you.

Problems in docs for preconditioner

@bo3mrh I believe you have introduced some issues in the fixes to the documentation for the Preconditioner. You use humid air properties on a humid-air basis in some places (\rho_{ha} for instance), while the units at the bottom are still on a dry-air basis. Please fix and file a pull request.

PHECycle.py:

File: "ACHP-master> Cycle Tests> PHECycle.py"
After running the file, the result shows: 'ValueError: math domain error'. What do we do to fix it?

CoolProp 6.1.1 gives an error with HP cycle mode

Hi,

I try to run CycleTest with Heat Pump Model, but I just got the following Error:

ValueError: HAProps failed ungracefully with inputs: "W","T",2.7852603934336025e+02,"P",1.0132500000000000e+05,"H",1.4114309647910737e+04

My python version is 3.6.1 | Anaconda 4.4.0 (64-bit)
I'm confused, is there something wrong with my python version?

Best Wishes

Fin Correlations

In FinCorrelations file, there are 2 issues:

1. The height and width of the fin is calculated with (N+1) where N is number of tubes or rows; this is based on assuming the fin extends 0.5 spacing on both sides at the end.

This is not accurate as there is (N-1) spacings between the tubes, and assuming (2*0.5) additional spacing on the ends would make the total number is (N) not (N+1)

2. WavyLouvered Fin correlations where Re is below 1000 has something wrong with it, there is discontinuity in the correlation before and after Re = 1000;

Ref/Liquid [R134a/POE32] not implemented: CompressorTest.py

When running the ACHP-master>ComponentTests>CompressorTest.py, the result indicates 'Ref/Liquid [R134a/POE32] not implemented'

Even when I replace R134a with R410a, the result still shows 'Ref/Liquid [R410a/POE32] not implemented'. Even when I change the Backend to the other refrigeration library, the results are still the same.

File: "ACHP-master> Cycle Tests> SampleCycles.py"

File: "ACHP-master> Cycle Tests> SampleCycles.py"

Here are some errors I met in this file.
-->AttributeError: DXCycleClass instance has no attribute 'Backend' --> this can be solved by adding Cycle.Backend='HEOS' into line 430(The DXCycleClass part)
-->AssertionError: Unmatched fields found:['Ref'] --> Refrigerant is R410a. How we resolve this problem?
I tried to run the SampleSecondaryLoopSystem separately and it works fine after putting into HEOS library(see test code). However, I cannot make the SampleCycles.py to work. Any suggestion on how to fix the code?

simulate a real heat pump system with heat storage and two-point control

First of all, many thanks for providing the code.
I want to use the cycle model in heat mode to simulate a real heat pump system.
In the real system, the heat pump is either switched on or off according to the temperatures in a heat storage tank.
Is it possible to simulate a longer period when the heat pump is switched on or off from time to time?

the formula at the line 307 in the FinCorrelation.py file is not correct

cp_ha=cp_da/(1+W) #[J/kg_ha/K]

GUI ACHPMainFrame

Hello, I am new to ACHP. But I am very interested in the code. My first test is on interface GUI. I encountered errors while Solve :
Traceback (most recent call last):
File ".\ACHPMainFrame.py", line 70, in RunCode
Cycle=GUI2DXCycleInputs(self)
File "C:\Users\Utilisateur\Travaux\ACHP\ACHP-1\GUI\ACHPFileIO.py", line 57, in GUI2DXCycleInputs
Cycle.Evaporator.DT_sh =float(GUI.txtCycleDTsh.GetValue())
AttributeError: DXCycleClass instance has no attribute 'Evaporator'

If you have any comments, it might help me alot. Thanks in advance.