certora/2023-01-blockswap-fv

2023-01-blockswap-fv's Issues

[informational] incorrect error thrown

In _registerKnotsToSyndicate the following line seems to throw the wrong error:

            if (getSlotRegistry().currentSlashedAmountOfSLOTForKnot(blsKey.unwrap(blsPubKey)) != 0) revert InvalidNumberOfCollateralizedOwners();

I think it should be throwing KnotSlashed

[informational] unused function

These functions are not used:

• _calculateCollateralizedETHOwedPerKnot
• _calculateNewAccumulatedETHPerCollateralizedShare

[informational] strange duplicate check in _addPriorityStakers

There is a check for duplicates in _addPriorityStakers:

    function _addPriorityStakers(address[] memory _priorityStakers) internal {
        uint256 numOfStakers = _priorityStakers.length;
        if (numOfStakers == 0) revert EmptyArray();
        for (uint256 i; i < numOfStakers; ++i) {
            address staker = _priorityStakers[i];

            if (i > 0 && staker < _priorityStakers[i-1]) revert DuplicateArrayElements();

            isPriorityStaker[staker] = true;

            emit PriorityStakerRegistered(staker);
        }
    }

This seems strange because a) if there are duplicates there is no harm caused to the contract because the mapping is just changed twice to true in the same place, b) the check will not catch all duplicates since it uses strict less than as apposed to <=.

Example array with duplicates that will not end in a revert:

[0x1, 0x1]

This duplicate check also makes the life of the caller unnecessarily difficult because they have to sort their array of addresses, which could be an expensive operation if the caller is another contract.