cetic / helm-adminer Goto Github PK
View Code? Open in Web Editor NEWHelm Chart for Adminer
License: Apache License 2.0
Helm Chart for Adminer
License: Apache License 2.0
Is your feature request related to a problem? Please describe.
Yes. From kubernetes 1.22 the kubernetes.io/ingress.class: nginx annotation will be deprecated. Should be using field spec.ingressClassName. We would like to implement it already.
Describe the solution you'd like
Add ingressClassName to ingress spec field. It's been added to kubernetes 1.18
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
name: elasticsearch-ingress
spec:
{{- if .Values.ingress.className }}
ingressClassName: {{ .Values.ingress.className | quote }}
{{- end }}
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Specifying the Class of an Ingress
A new ingressClassName field has been added to the Ingress spec that is used to reference the IngressClass that should be used to implement this Ingress.
Deprecating the Ingress Class Annotation
Before the IngressClass resource was added in Kubernetes 1.18, a similar concept of Ingress class was often specified with a kubernetes.io/ingress.class annotation on the Ingress. Although this annotation was never formally defined, it was widely supported by Ingress controllers, and should now be considered formally deprecated.
You are supporting setting labels for service and ingress, why not also add it to the pod itself? Also, adding selectors to values.yaml will be also helpful, for user to be able to filter the adminer pod easily.
helm-adminer/templates/ingress.yaml
Line 5 in 5a67c86
apiVersion: extensions/v1beta1 is depricated and can't be used in kuberentes 1.22+, need to use
apiVersion: networking.k8s.io/v1 instead.
Please approve and merge this pull request which will fix the issue:
This chart is not maintained anymore, feel free to fork it and advertise your fork here so users can find alternatives.
In your description Steam support helm 2, but when I try to install applications I get this error due to the fact that I use helm 2 versions
helm install --name adminer --namespace=data cetic/adminer
Error: apiVersion 'v2' is not valid. The value must be "v1"
Is your feature request related to a problem? Please describe.
add @fzalila a chart maintainer.
Looking in the chart there doesn't seem to be any possibility to vary the probes
Could you add them to the chart?
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.