cetic/helm-adminer

Helm Chart for Adminer

helm-adminer's Issues

[cetic/adminer] Add ingressClassName field to ingress manifest

Is your feature request related to a problem? Please describe.
Yes. From kubernetes 1.22 the kubernetes.io/ingress.class: nginx annotation will be deprecated. Should be using field spec.ingressClassName. We would like to implement it already.

Describe the solution you'd like
Add ingressClassName to ingress spec field. It's been added to kubernetes 1.18

apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: elasticsearch-ingress
spec:
  {{- if .Values.ingress.className }}
  ingressClassName: {{ .Values.ingress.className | quote }}
  {{- end }}

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context

https://kubernetes.io/blog/2020/04/02/improvements-to-the-ingress-api-in-kubernetes-1.18/#specifying-the-class-of-an-ingress

Specifying the Class of an Ingress

A new ingressClassName field has been added to the Ingress spec that is used to reference the IngressClass that should be used to implement this Ingress.

Deprecating the Ingress Class Annotation

Before the IngressClass resource was added in Kubernetes 1.18, a similar concept of Ingress class was often specified with a kubernetes.io/ingress.class annotation on the Ingress. Although this annotation was never formally defined, it was widely supported by Ingress controllers, and should now be considered formally deprecated.

[cetic/adminer] Support custom label setting for pod itself

You are supporting setting labels for service and ingress, why not also add it to the pod itself? Also, adding selectors to values.yaml will be also helpful, for user to be able to filter the adminer pod easily.

Depricated apiVersion

helm-adminer/templates/ingress.yaml

Line 5 in 5a67c86

apiVersion: extensions/v1beta1

apiVersion: extensions/v1beta1 is depricated and can't be used in kuberentes 1.22+, need to use
apiVersion: networking.k8s.io/v1 instead.

Please approve and merge this pull request which will fix the issue:

#6

Add MongoDB support

Chart is not maintained anymore | advertise your fork here

This chart is not maintained anymore, feel free to fork it and advertise your fork here so users can find alternatives.

[cetic/adminer] Helm 2 support

In your description Steam support helm 2, but when I try to install applications I get this error due to the fact that I use helm 2 versions
helm install --name adminer --namespace=data cetic/adminer
Error: apiVersion 'v2' is not valid. The value must be "v1"

[cetic/adminer] add @fzalila as a maintainer

Is your feature request related to a problem? Please describe.
add @fzalila a chart maintainer.

cetic/fadi#132

[cetic/adminer] livenessProbe and readinessProbe

Looking in the chart there doesn't seem to be any possibility to vary the probes
Could you add them to the chart?