Refactor of Constructor to use std::string looses default value

[cevelop]

Refactor of Constructor to use std::string looses default value

[tcorbat]

This behavior is indeed strange. It also happens for other member and non-member functions. We'll look into that.

[tonisuter]

Thanks for the bug report! Currently, this refactoring only works with functions that contain a null-check for the C-string parameter. It will then generate a duplicate of the function with a std::string parameter and delegate to that function if the string is not null. Here's an example:

#include <iostream>

void login(const char *pw) {
    if(!pw) {
        std::cout << "missing password!\n";
        return;
    }

    if(strcmp(pw, "123456") == 0) {
        std::cout << "login successful!\n";
    } else {
        std::cout << "wrong password!\n";
    }
}

int main() {
    login(nullptr);		// missing password!
    login("password");	    // wrong password!
    login("123456");	    // login successful!
}

#include <iostream>
#include <string>

void login(const std::string& pw) {
    if (pw == "123456") {
        std::cout << "login successful!\n";
    } else {
        std::cout << "wrong password!\n";
    }
}

void login(const char *pw) {
    if(!pw) {
        std::cout << "missing password!\n";
        return;
    }
    login(std::string(pw));
}

int main() {
    login(nullptr);		// missing password!
    login("password");	    // wrong password!
    login("123456");		// login successful!
}

Anyway, I fixed this issue on the master branch and the fix will be part of the next Cevelop release.