Comments (14)
Mapping properties from inherited class should be supported. Could you show code of your classes?
from mappinggenerator.
When I try to generate mapping from Child Entity to Child Model, I get this(ignore the recursion code - this is just an illustration):
And when I do it the other way round - Child Model to Child Entity, this is the result:
Notice that in the first case there isn't an Id column mapping, while in the second there is. Maybe I am doing something wrong?
from mappinggenerator.
Are these classes in the same assembly?
from mappinggenerator.
Yes, they are. Just different namespaces.
from mappinggenerator.
Ok, I've just found the culprit, ModelBase.Id
has setter with internal
modifier. I need to handle this case. but it can take a while. I have no idea how to check if element with internal modifier is accessible in given context.
from mappinggenerator.
I've found code that check if two types are from different assemblies but this requires a lot of changes because we need to pass context of code generation
https://github.com/dotnet/roslyn/blob/master/src/Workspaces/Core/Portable/Shared/Extensions/ISymbolExtensions_Accessibility.cs
from mappinggenerator.
@phoenix172 Could you test this version https://ci.appveyor.com/api/buildjobs/v2ooime65b205pff/artifacts/MappingGenerator%2FMappingGenerator%2FMappingGenerator.Vsix%2Fbin%2FRelease%2FMappingGenerator.vsix and tell me if all mappings works correctly?
from mappinggenerator.
Confirmed working. Nice job and thank you :)
from mappinggenerator.
I guess you would want to close this with a commit :)
from mappinggenerator.
Oh just found a new problem that I am not sure was present with the old version.
The Generate Mapping option does not appear when the cursor is at the end of the method name.
If this is not just the new version, I can open a separate issue.
from mappinggenerator.
This problem is not related with the original issue but there is no need to create another ticket. I will check that tomorrow.
from mappinggenerator.
@phoenix172 would you be so kind to test the new version? https://ci.appveyor.com/api/buildjobs/mnxgommposnkhw7q/artifacts/MappingGenerator%2FMappingGenerator%2FMappingGenerator.Vsix%2Fbin%2FRelease%2FMappingGenerator.vsix
from mappinggenerator.
Works great :)
from mappinggenerator.
Thanks for testing. Fix merged into develop, should be released in few days.
from mappinggenerator.
Related Issues (20)
- NullReferenceException on omitted type parameter HOT 4
- Source Generators HOT 4
- Mapping properties of one type on another HOT 1
- Inconsistent behaviour HOT 17
- Implement Clone Method refactoring has issues with arrow functions
- Allow different spellings for comparison HOT 6
- Use the existing instance instead of creating a new one HOT 9
- Generate unit tests HOT 3
- Suggestion: Scaffold invocation on multiple lines. HOT 2
- Suggestion: Varying sample data HOT 3
- Could not load type 'MappingGenerator.Features.CodeFixes.ExplicitConversionCodeFixProvider' HOT 12
- How do I "Verify your Roslyn integration option in case you are using R#."? HOT 2
- VSCode extention ? HOT 1
- ValueCollection appears to cause crash on Quick Action HOT 3
- UnitTest generator? HOT 2
- Visual Studio Performance slowing down HOT 1
- Fix NuGet package OnBuildGenerator HOT 4
- Improve interaction with `[InitRequired]` HOT 6
- Mapping from nullable structs to simple value handled incorrectly
- Generating mapping expression for C# 9 positional records HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mappinggenerator.