Expand use beyond organization level

[JuanFCabrera]

Expand use beyond organization level

[pacphi]

Whitelisting and blacklisting only apply to organizations. What is the use case? Do you want to report on or act on (a) specific application(s)? If the former you might consider the use of a Query Policy. If the latter (e.g., a delete policy), then we'd have to look at updating the logic in the isBlackListed and isWhiteListed methods. ApplicationPolicy would need to hold some additional state, maybe a Map<String, String> named spacesWhiteList, where the key is the organization name and the value is the space name? I'm a little weary of going down this path without some more design thought (allowing for more flexible definitions of whitelists).

[JuanFCabrera]

Chris, Our use case would be as follows, set up a policy where it works through a delete policy for org A and E but skips spaces C and G. we have some application teams the startup certain applications once or twice a week within those specific spaces to do data validation. The other spaces in the Org we would like the policy to run through. Org A Space B Space C Space D Org E Space F Space G From: Chris Phillipson ***@***.***> Sent: Monday, April 19, 2021 9:18 AM To: pacphi/cf-butler ***@***.***> Cc: Cabrera, Juan (Penske) ***@***.***>; Author ***@***.***> Subject: [EXTERNAL] Re: [pacphi/cf-butler] Expand use beyond organization level (#358) This email originated from a Non-Penske sender. DO NOT OPEN attachments or links unless you recognize the sender and know that the content is safe.

[pacphi]

I suppose we need to satisfy both whitelist (includes) and blacklist (exclude) spaces. The latter seems like what you want, and wouldn't be too difficult to add.

Maybe the configuration could be adapted like so...

Sample application.yml

cf:
  spaceBlackList:
     - "Org-A:Space-A"
     - "Org-E:Space-A"
     - "Org-E:Space-B"
     - "Org-E:Space-C" 
     - "Org-E:Space-D" 

And then we'd add a Set<String> spacesBlackList to PasSettings.java and a companion accessor method.

And if the operator defined a spacesBlackList in addition to an orgBlackList it should take precedence over the orgBlackList for the same organization(s).

[pacphi]

@JuanFCabrera Give this feature implementation branch a try. Consult the README update for how to specify the black list. It should be implemented as I describe above.

[pacphi]

The feature branch has been merged to the main line.