Is StopApplicationPolicy functioning correctly?

[erboucherie]

Is StopApplicationPolicy functioning correctly?

[pacphi]

The filter(s) for ApplicationPolicy are here

• https://github.com/pacphi/cf-butler/blob/master/src/main/java/io/pivotal/cfapp/repository/R2dbcAppDetailRepository.java#L55
• https://github.com/pacphi/cf-butler/blob/master/src/main/java/io/pivotal/cfapp/repository/R2dbcAppDetailRepository.java#L80

and likewise for ServiceInstancePolicy

• https://github.com/pacphi/cf-butler/blob/master/src/main/java/io/pivotal/cfapp/repository/R2dbcServiceInstanceDetailRepository.java#L64

These filters rely on the capture of event data associated with an AI or SI which happens on collection.

• https://github.com/pacphi/cf-butler/blob/master/src/main/java/io/pivotal/cfapp/task/AppDetailTask.java#L93

  • https://github.com/pacphi/cf-butler/blob/4597b19085f874af8b3f6dce870c78303de0353a/src/main/java/io/pivotal/cfapp/task/AppDetailTask.java#L144

• https://github.com/pacphi/cf-butler/blob/4597b19085f874af8b3f6dce870c78303de0353a/src/main/java/io/pivotal/cfapp/task/ServiceInstanceDetailTask.java#L84

I don't know if you caught it, but in the filters for AppPolicy we use last_event_time rather than last_pushed. This was a choice based on potential that the app instance could have crashed and been re-started. I wonder if it makes sense in the policy definition to allow for you to specify whether you want to use last_event_time or last_pushed, defaulting to the former for consistency/compatibility's sake?

Have a go updating the filter logic yourself, and let me know what you find out.

[erboucherie]

Thank you very much for this very detailed explanation . Now i understand why my application is not stopped based on the last_event_time rather than the last_pushed which is in the description of the file i took as a basis .
In our thought , last_pushed was most representing the LCM of the application , and so we could deduce that an application is living or not .
But now that this is well understood how it works , it depends on us what we will choose .
Thanks again

[pacphi]

Closing