cgarvis/martini-etag

ETag support for Martini

martini-etag's Issues

ETag to the martini contrib?

I think this small piece of code would be great candidate for the martini contrib collection. Don't you think?

Header isn't set with multiple return values

In the following example, /a will return an ETag header and /b won't.

package main

import . "github.com/cgarvis/martini-etag"
import "github.com/codegangsta/martini"

func main() {
    m := martini.Classic()
    m.Use(ETag())                                                                                                                                                                                         
    m.Get("/a", func() string {
        a := make([]byte, 2000)
        return string(a)
    })
    m.Get("/b", func() (int, string) {
        b := make([]byte, 2000)
        return 200, string(b)
    })
    m.Run()
}

No Etag When Using `martini-contrib/render` to JSON

I'm using "github.com/martini-contrib/render" to render r.JSON(200, userStruct) and no Etag header is being added. I've checked some of the none-json routes and I have the same issue.

I'm basically doing:

func main() {
  m := martini.Classic()
  m.Use(ETag())
  var appEnv *AppEnv = LoadEnv()
  m.Map(appEnv)
  m.Use(render.Renderer())
  appName.RegisterRoutes(m)
  m.Run()
}

func RegisterRoutes(m *martini.ClassicMartini) {
  m.Get("/status", func(r render.Render) {
    r.Text(200, "SUCCESS")
  })
}

Confusing Example

I think the README should be updated with an example that sends >= 1024 bytes. An example that sends an ETag would be less confusing.