charlesbaynham/digitaltemperaturecontroller

Schematic, PCB and source code for a high-precision digital temperature controller

digitaltemperaturecontroller's Issues

ES pins floating or driven high for 2 channel configuration.

Hi Charles

I would like to first of all thank you for posting this project on GitHub, I really enjoyed going through your microcontroller C++ code and expanding my knowledge of C++ from the more basic concepts to more sophiscated methods e.g usage of pointers to pointers, references to pointers and virtualisation.

As you may know I am working alongside Sarah (Sr group at the University of Birmingham) to get the 2 channel board configuration running. The first change I have made is in the Pins.h file to uncomment pin_2chan.h and comment pins_4chan.h. However when uploading this code, whilst enabling the vertical switch, I get the error that 'ES_FLOAT_ON' is not referenced in the subsequent files e.g V4_OPA_OutputChannelBipolar.cpp.

An ad hoc solution would be to enter const bool ES_FLOAT_ON = false; in the pins_2chan.h file. I have set the ES pins to be driven high because you have done the same for the 4 channel configuration in the latest version version 5 in Pin_4chan.h file. Would I be right in doing this, I wanted to ask you before implementing it? I have read through all of the manual but I don't know if I have missed a step.

PS: On an unrelated note, I have seen your posts on the M-labs forum regarding the ARTIQ scheduler, I had also posted on the same thread. Given your experience with ARTIQ would you be willing to have a one-off 15 minute zoom meeting to discuss your ARTIQ system. I understand it is a completely different experimental setup but I would really appreciate an opportunity to talk to someone else working on an ARTIQ system and discuss issues regarding experimental scheduling and the compiler.

Documentation should automatically compile

The pdf documentation should use CI to automatically compile from the code. If not this, then at least it should be easy to do! Currently the pdf committed to this repository is out-of-sync with the code (see #1).

Error in commands

Hi Charles,

I am a research fellow in Sr atoms group at the University of Birmingham. One of my colleagues recommended your design for temperature controllers for high finesse cavities. Thank you very much for providing this design and all the documents!

I have got some PCBs manufactured based on your design, and I have established the communication between the microcontroller and a computer. However, I am having issues with some commands.

The first issue is the Error in startup commands. This error shows up first every time the board is connected.

The second issue is the Error in some of the commands. I found the error only shows up for all the commands that the number of parameters is not 0.

I attached a picture here to give some examples, the first line shows the startup error. The second line is when I sent *TST and I got 'loud and clear' in return without an issue. The third line is when I sent 'LOCK' command but got an error.

I don't have much experience in C++ or Arduino, if you could help with any ideas, that would be very helpful!

Also please can I ask should I use Labview files as a user interface, once I have got the C++ programme running?

Again, thank you very much for the design, and I appreciate any answers.

Best regards,
Sarah