charlesndalton/milkman

A smart contract system which allows smart contracts, including Gnosis Safes, to route their order flow through the CoW protocol with market orders.

milkman's Issues

How to test ?

I am working on a protocol that need to swap some tokens (relatively small amounts), I want those swaps to be permissionless, so using the milkman looks like a good idea, but I am missing 2 things:

1. Some kind of callback notifying the swap was executed, can be called back even after a few hours.
2. A way to test/simulate an executed trade, testing on a local network without solvers will never execute.

Do you have any suggestions how to tackle those issues ?

feature request: return the "order contract" address from `requestSwapExactTokensForTokens`

It'd be helpful to have access to the order contract address when calling requestSwapExactTokensForTokens from another contract so that cancelSwap can be called without requiring the order contract address to be provided by the caller.

feature request: add temporary asset holder getter

After swap has been called & before the swap is executed, the assets are held by a contract deployed for the each specific swap.

When users are testing that the swaps are correctly implemented, we also wanna check that the correct assets and amounts were transfered to this new "order proxy" contract.

a view only function that returns this newly created address would help a lot with the usability

feel free to close if useless :)

great job, keep up the great work