Giter Site home page Giter Site logo

cassette-express's People

Contributors

avnerus avatar kevinkuebler avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

cassette-express's Issues

Windows paths not handled correctly

Thanks for creating this package! I'm hoping to use it on a production site sometime soon. However, there's a blocking issue for us which is that it doesn't work when using node on Windows, and it looks like the problems are related to file paths. Starting with just a clone of the repo and changing to the Example directory, I ran npm install and then node app.js. This immediately throws the following error:

fs.js:400
  return binding.readdir(pathModule._makeLong(path));
Error: ENOENT, no such file or directory 'D:\node_modules'
    at Object.readdirSync (fs.js:400:18)
    at base.scanDirectory (D:\Dev\Cassette-Express\EXAMPLE\node_modules\cassette-express\lib\manifest.js:32:18)
    at base.reset (D:\Dev\Cassette-Express\EXAMPLE\node_modules\cassette-express\lib\manifest.js:122:8)
    at base.init (D:\Dev\Cassette-Express\EXAMPLE\node_modules\cassette-express\lib\manifest.js:24:8)

The problem stems from the call this.scanDirectory( node );on line 119 of manifest.js. The call to path.relative on the preceding line results in a path like ..\..\..\..\..\node_modules in my case (I have the repo located at D:\dev\cassette-express on my system). So that resolves to D:\node_modules which doesn't exist.

I'm not sure exactly why it's trying to scan the node_modules folder, but if I take that line out the app will run. But then another path problem becomes apparent. If I browse to localhost:3000 the page loads but none of the scripts get loaded. And that's because if you look at the source, it's rendering script tags with a src attribute like this:

src="\javascripts\lib\underscore.js"

Notice that the src is using \ instead of / which is preventing the browser from loading them.

If I can figure out what exactly needs changed in the source to fix these issues, I'll be happy to issue a pull request. Not sure how long it will take me to figure out what's going on though. :-)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.