chauntevandeburgh / colmar-academy Goto Github PK
View Code? Open in Web Editor NEWHome Page: https://chauntevandeburgh.github.io/colmar-academy/
Home Page: https://chauntevandeburgh.github.io/colmar-academy/
Be careful when you are using width: 100% and padding/margin as this can cause an element to be larger than the page. Here even this small margin creates a minor side scroll issue on your mobile page.
https://github.com/ChaunteVanDeBurgh/colmar-academy/blob/master/resources/css/index.css#L230
The more selectors you chain together the more rigid and less reusable your CSS. Ideally, you don't want to use more than 2 chained together. When you find yourself chaining more than that you are better off creating a new class for that styling. I would check out the BEM naming convention for CSS for more details:
http://getbem.com/introduction/
https://github.com/ChaunteVanDeBurgh/colmar-academy/blob/master/resources/css/index.css#L67
You are using a lot of id chained selectors. This means that all this styling you're doing for each of these components is non-reusable. When you start getting into larger projects with multiple html pages you really are going to want reusable classes in the css.
https://github.com/ChaunteVanDeBurgh/colmar-academy/blob/master/resources/css/index.css#L189-L270
Your HTML looks very good. I like the usage of alt attributes and semantic tags. You can extend your semantic tag usage even further and you can use more than 1 <nav>
as well. Here is a good article on semantic tag usage:
https://www.pluralsight.com/guides/html-css/semantic-html?aid=701j0000001heIqAAI&promo=&oid=&utm_source=google&utm_medium=ppc&utm_campaign=CA_Dynamic&utm_content=&utm_term=&gclid=CjwKCAjwlrnNBRBMEiwApKU4PBiUM7wtxiyqNw-6Zoikh6ChlNul6tTL839Zj2h_JNTZcK6PE5WWlRoCiOYQAvD_BwE
https://github.com/ChaunteVanDeBurgh/colmar-academy/blob/master/index.html
Grade: Satisfactory
Summary: Nice job on this project, the site looks very good. I like the style enhancements you made and you used a lot of good techniques in the code. Take a look at the issues I created for some best practice tweaks as well as some new techniques you can look into. Overall well done, I hope you enjoyed the course!
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.