Giter Site home page Giter Site logo

bettersorting's People

Contributors

absnormal avatar chobitscrazy avatar chobitscrazytest avatar elzetia avatar fabfixxx avatar fanghanhu avatar franisz avatar likayo avatar ncrawler avatar rostik18 avatar setig avatar vitsumi avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

bettersorting's Issues

Is Item Tweaker API a requirement

I tried to use BetterSorting on a local hosted Server ( not dedicated ) and after creating my character i get an error:
File doesn´t exist on server:
media/lua/shared/itemtweaker_copy_cc.lua

So I like to know if item tweaker is needed because its not listed as a dependency.

Gamepad Controller Problemwith context menu

Have 2 players attempting to use gamepads while playing on the server. They receive this error and get locked out of the context menu. We have tracked the issue down to this mod.
Here is the error log.
function: doContextOnJoypadSelected -- file: ISInventoryPane.lua line # 1399 | Vanilla
function: onJoypadDown -- file: ISInventoryPage.lua line # 674 | Vanilla
function: onPressButton -- file: JoyPadSetup.lua line # 345 | Vanilla
function: update -- file: JoyPadSetup.lua line # 779 | Vanilla
function: onJoypadRenderTick -- file: JoyPadSetup.lua line # 796 | Vanilla
java.lang.RuntimeException: attempted index of non-table
at se.krka.kahlua.vm.KahluaUtil.fail(KahluaUtil.java:82)
at se.krka.kahlua.vm.KahluaUtil.luaAssert(KahluaUtil.java:70)
at se.krka.kahlua.vm.KahluaThread.tableSet(KahluaThread.java:1726)
at se.krka.kahlua.vm.KahluaThread.luaMainloop(KahluaThread.java:594)
at se.krka.kahlua.vm.KahluaThread.call(KahluaThread.java:163)
at se.krka.kahlua.vm.KahluaThread.pcall(KahluaThread.java:1980)
at se.krka.kahlua.vm.KahluaThread.pcallvoid(KahluaThread.java:1812)
at se.krka.kahlua.integration.LuaCaller.pcallvoid(LuaCaller.java:66)
at se.krka.kahlua.integration.LuaCaller.protectedCallVoid(LuaCaller.java:139)
at zombie.Lua.Event.trigger(Event.java:64)
at zombie.Lua.LuaEventManager.triggerEvent(LuaEventManager.java:65)
at zombie.GameWindow.frameStep(GameWindow.java:778)
at zombie.GameWindow.run_ez(GameWindow.java:681)
at zombie.GameWindow.mainThread(GameWindow.java:495)
at java.base/java.lang.Thread.run(Unknown Source)

Move the contents of the mod to shared.

Item script changes are not sync'd on the server side. If a mod has server-side code this causes issues when you need to compare the scripts/items' values.

VFE STALKER Expansion

Here is my contribution to the mod by adding VFE STALKER Expansion (ID:"VFExpansion2")

The items added by the mod are under the Base module; idk if it should show in my game if I add the strings to the additional mod file but it doesn't show up so I'm pullin the request here. Salute! Ty for the best mod ever.

require("ItemTweaker_Copy_CC");

--VFES
--https://steamcommunity.com/sharedfiles/filedetails/?id=2893333090
if getActivatedMods():contains("VFExpansion2") then
TweakItem("Base.Mosin","DisplayCategory","WepFire");
TweakItem("Base.Saiga12","DisplayCategory","WepFire");
TweakItem("Base.SVD","DisplayCategory","WepFire");
TweakItem("Base.Galil","DisplayCategory","WepFire");
TweakItem("Base.UMP45","DisplayCategory","WepFire");
TweakItem("Base.Makarov","DisplayCategory","WepFire");
TweakItem("Base.USP45","DisplayCategory","WepFire");
TweakItem("Base.SV98","DisplayCategory","WepFire");
TweakItem("Base.M249","DisplayCategory","WepFire");
TweakItem("Base.PKM","DisplayCategory","WepFire");
TweakItem("Base.Vityaz","DisplayCategory","WepFire");
TweakItem("Base.HK416","DisplayCategory","WepFire");
TweakItem("Base.VSS","DisplayCategory","WepFire");
TweakItem("Base.SVT40","DisplayCategory","WepFire");
TweakItem("Base.MP153","DisplayCategory","WepFire");
TweakItem("Base.MP153sawn","DisplayCategory","WepFire");
TweakItem("Base.762Clip10","DisplayCategory","WepAmmoMag");
TweakItem("Base.939Clip10","DisplayCategory","WepAmmoMag");
TweakItem("Base.556box100","DisplayCategory","WepAmmoMag");
TweakItem("Base.762box100","DisplayCategory","WepAmmoMag");
TweakItem("Base.12Clip5","DisplayCategory","WepAmmoMag");
TweakItem("Base.762Clip102","DisplayCategory","WepAmmoMag");
TweakItem("Base.762Clip103","DisplayCategory","WepAmmoMag");
TweakItem("Base.9mmClip8","DisplayCategory","WepAmmoMag");
TweakItem("Base.45Clip12","DisplayCategory","WepAmmoMag");
TweakItem("Base.45Clip25","DisplayCategory","WepAmmoMag");
TweakItem("Base.9mmClip302","DisplayCategory","WepAmmoMag");
end

Sort by Favorite

I frequently use the favorites function to make sure I don't accidentally move something I don't want to. But what would be even better is if all my favorites were kept together, so I could easier find the non-favorite stuff in my bags or inventory.

Empty White Mug vs Empty Mug

Empty White Mug is 'Container' while Empty Mug is 'Cooking'. Is there any specific reason they're not in the same category? I don't see any difference...

Add additional sorting categories

This mod is very useful in combination with this other mod Manage Containers. It allows you to add categories to some container, and when you get back from a loot trip, to instantly dump each item in the correct container. Big quality of life feature.

However some categories are lacking precision and as such some items cannot be instant sorted as we would like.

I propose adding the following categories:
Cooking - Ustentils (bowls, pans, saucepans...)
Cooking - Condiments (salt, maple syrups, vegetable oil...)
Cooking - Ingredients (flour, brown sugar, baking soda...)
Container - Bottles
Tool - Carpentry (hammer, ball-peen hammer...)
Tool - Mechanics (tire pump...)
Tool - Lights (flashlight, hand torch...)
Tool - Tailoring (scissors...)
Tool - Farming (gardening spray, shovel...)
Food - Fishing baits (worm, cricket, grasshopper...)
Food - Perishable meals (any meal prepared by the player)
Food - Perishable freeze-sensitive (ice cream (when it's not melted)...)
Food - Non-Perishable canned (any can that needs to be opened with a can opener)
Food - Non-Perishable spices (butter, marinara, ketchup, mayonnaise, tomato paste...)

Idea: merge Cooking - condiments (which right now are just cooking) and Food - Non-Perishable spices (which right now are Food - Non-Perishable) into one category, like Food - Non-Perishable spices & condiments

I'd also like to create categories that contain only one item, but this point I understand if you don't wish to add in your mod. I would like them for instant sorting. Problem with some of these is they overlap between categories (Needle can be used for tailoring and medical, screwdriver can be used for electronics and mechanics) :

  • Tool - Needle containing only the needle
  • Tool - Screwdriver containing only the screwdriver

Please let me know if this is in line with what you want for this mod. If you agree to this idea but cannot do the change yourself I could look into how to do this and create a PR tho I've never done this for PZ.

Sorting propose for SmallMod_Items.lua

I made some sorting changes, hopefully the will be added

--Tsar's Common Library 2.0
--https://steamcommunity.com/sharedfiles/filedetails/?id=2392709985
if getActivatedMods():contains("tsarslib") then
TweakItem("Base.1000Tank1","DisplayCategory","Mechanics");
TweakItem("Base.1000Tank2","DisplayCategory","Mechanics");
TweakItem("Base.1000Tank3","DisplayCategory","Mechanics");
TweakItem("Base.500Tank1","DisplayCategory","Mechanics");
TweakItem("Base.500Tank2","DisplayCategory","Mechanics");
TweakItem("Base.500Tank3","DisplayCategory","Mechanics");
TweakItem("Base.ATA2.ATA2ItemContainer","DisplayCategory","Mechanics");
TweakItem("Base.ATAProtectionWheelsChain","DisplayCategory","Mechanics");
TweakItem("Base.ATARoofLightItem","DisplayCategory","Mechanics");
TweakItem("Base.ATASleepingBag","DisplayCategory","Mechanics");
TweakItem("Base.TransportSeatBoxWooden","DisplayCategory","Mechanics");
TweakItem("Base.TransportMicrowave","DisplayCategory","Furniture");
TweakItem("Base.TransportOven","DisplayCategory","Furniture");
TweakItem("Base.TransportShelve","DisplayCategory","Furniture");
TweakItem("Base.TransportCounter","DisplayCategory","Furniture");
TweakItem("Base.TransportMedicine","DisplayCategory","Furniture");
TweakItem("Base.TransportDrawer","DisplayCategory","Furniture");
TweakItem("Base.TransportFreezer","DisplayCategory","Furniture");
TweakItem("Base.TransportFridge","DisplayCategory","Furniture");
TweakItem("Base.TransportCupboard","DisplayCategory","Furniture");
end

--Irrigation pipes for farming and water supply [B41+]
--https://steamcommunity.com/sharedfiles/filedetails/?id=2464581798
if getActivatedMods():contains("waterPipes") then
TweakItem("waterPipes.WaterPipe2","DisplayCategory","Material");
TweakItem("waterPipes.WaterPipe","DisplayCategory","Material");
end

--Can Repair Doors
--https://steamcommunity.com/sharedfiles/filedetails/?id=2905027525
if getActivatedMods():contains("CanRepairDoors") then
TweakItem("Base.DoorsRepairKitMetal","DisplayCategory","Tool");
TweakItem("Base.DoorsRepairKitWood","DisplayCategory","Tool");
TweakItem("Base.DoorsRepairKitEpoxy","DisplayCategory","Tool");
end

--Essential Crafting
--https://steamcommunity.com/sharedfiles/filedetails/?id=2903127760
if getActivatedMods():contains("EssentialCrafting") then
TweakItem("Base.LighterEmpty","DisplayCategory","Tool");
end

Sorting Error

Since your last update, for some reason Carpentry 1 is now being sorted to the bottom of my skill literature. I generally use sort by category and have never had any issues before. Just wanted to let you know. Thanks!

Adding some Snake Advanced Fishing Books

--Advanced Fishing Books
TweakItems("AdvancedFishing.FishingAnglerBook1","DisplayCategory","LitS");
TweakItems("AdvancedFishing.FishingAnglerBook2","DisplayCategory","LitS");
TweakItems("AdvancedFishing.FishingAnglerBook3","DisplayCategory","LitS");
TweakItems("AdvancedFishing.FishingAnglerBook4","DisplayCategory","LitS");
TweakItems("AdvancedFishing.FishingAnglerBook5","DisplayCategory","LitS");
TweakItems("AdvancedFishing.FishingAnglerBook6","DisplayCategory","LitS");
TweakItems("AdvancedFishing.FishingAnglerBook7","DisplayCategory","LitS");
-- Advanced Fishing Encyclopedias
TweakItems("AdvancedFishing.FishingEncyclopedia","DisplayCategory","LitS");
TweakItems("AdvancedFishing.FishingEncyclopedia1","DisplayCategory","LitS");
TweakItems("AdvancedFishing.FishingEncyclopedia2","DisplayCategory","LitS");
TweakItems("AdvancedFishing.FishingEncyclopedia3","DisplayCategory","LitS");
TweakItems("AdvancedFishing.FishingEncyclopedia4","DisplayCategory","LitS");
TweakItems("AdvancedFishing.FishingEncyclopedia5","DisplayCategory","LitS");

TweakItems("AdvancedFishing.SportFishingBook","DisplayCategory","LitR");

Enquiry: Adding Categories Manually

Hello,
sorry for opening this as an issue. I'm a player who gets annoyed that when I loot a zombie for their clothes to rip, I always have to avoid selecting a pair of Shoes that appear in the middle of the list between the clothes I want to tear.
I was planning to add a new category "Clothing - Footwear" by myself to solve my own inconvenience, but I am not familiar with the lua scripts and I decided to reach out for some help.

I am concerned about a few things:

a. if I created a new mod mirroring your structure to add "ClothF", will it conflict with or be overwritten by the current script from your mod when I run both on my server?
I ask this because I see that the mod also tweaks the shoes:

TweakItem("Base.Shoes_ArmyBoots","DisplayCategory","Cloth");

b. I also browsed lua\shared\Translate\EN\. I roughly understood ItemName_EN.txt, but in IG_UI_EN.txt, I do not understand IGUI_ItemCat. How does TweakItem(itemName, "DisplayCategory", propertyValue) convert DisplayCategory = propertyValue = "Cloth" to "Clothing"?
Do I simply add a definition for "IGUI_ItemCat_ClothF = "Clothing - Footwear", and then TweakItem() will work with "ClothF"?

Again, sorry if this is not a good place to discuss. Any sort of reply will be appreciated!

Mod Support: Pantry Packing

I noticed the Pantry Packing Addon has Better Sorting support, but the base Pantry Packing mod does not. So here it is to be added to Better Sorting!

require("ItemTweaker_Copy_CC")

--PantryPacking
TweakItem("Base.BookBox","DisplayCategory","LitS");
TweakItem("Base.BookBoxCarpentry","DisplayCategory","LitS");
TweakItem("Base.BookBoxTrapping","DisplayCategory","LitS");
TweakItem("Base.BookBoxFishing","DisplayCategory","LitS");
TweakItem("Base.BookBoxMechanics","DisplayCategory","LitS");
TweakItem("Base.BookBoxFirstAid","DisplayCategory","LitS");
TweakItem("Base.BookBoxMetalwork","DisplayCategory","LitS");
TweakItem("Base.BookBoxElectricity","DisplayCategory","LitS");
TweakItem("Base.BookBoxCooking","DisplayCategory","LitS");
TweakItem("Base.BookBoxFarming","DisplayCategory","LitS");
TweakItem("Base.BookBoxForaging","DisplayCategory","LitS");
TweakItem("Base.BookBoxTailoring","DisplayCategory","LitS");
TweakItem("Base.BoxOfCereal","DisplayCategory","FoodN");
TweakItem("Base.BoxOfRedCrisps","DisplayCategory","FoodN");
TweakItem("Base.BoxOfYellowCrisps","DisplayCategory","FoodN");
TweakItem("Base.BoxOfBlueCrisps","DisplayCategory","FoodN");
TweakItem("Base.BoxOfGreenCrisps","DisplayCategory","FoodN");
TweakItem("Base.BoxOfChocolate","DisplayCategory","FoodN");
TweakItem("Base.BoxOfCoffee2","DisplayCategory","FoodN");
TweakItem("Base.BoxOfCookie","DisplayCategory","FoodN");
TweakItem("Base.BoxOfCupcake","DisplayCategory","FoodN");
TweakItem("Base.BoxOfMacandcheese","DisplayCategory","FoodN");
TweakItem("Base.BoxOfPeanutButter","DisplayCategory","FoodN");
TweakItem("Base.BoxOfCookieJelly","DisplayCategory","FoodN");
TweakItem("Base.BoxOfTVDinner","DisplayCategory","FoodN");
TweakItem("Base.BoxOfRamen","DisplayCategory","FoodN");
TweakItem("Base.BoxOfPopcorn","DisplayCategory","FoodN");
TweakItem("Base.BoxOfPasta","DisplayCategory","FoodN");
TweakItem("Base.BoxOfFlour","DisplayCategory","FoodN");
TweakItem("Base.BoxOfRice","DisplayCategory","FoodN");
TweakItem("Base.BoxOfSugar","DisplayCategory","FoodN");
TweakItem("Base.BoxOfTeabag2","DisplayCategory","FoodN");
TweakItem("Base.BoxOfVinegar","DisplayCategory","FoodN");
TweakItem("Base.BoxOfCocoaPowder","DisplayCategory","FoodN");
TweakItem("Base.BoxOfMapleSyrup","DisplayCategory","FoodN");
TweakItem("Base.BoxOfSoySauce","DisplayCategory","FoodN");
TweakItem("Base.BoxOfVegOil","DisplayCategory","FoodN");
TweakItem("Base.BoxOfBeans","DisplayCategory","FoodN");
TweakItem("Base.BoxOfBolognese","DisplayCategory","FoodN");
TweakItem("Base.BoxOfCanCarrots","DisplayCategory","FoodN");
TweakItem("Base.BoxOfCanChili","DisplayCategory","FoodN");
TweakItem("Base.BoxOfCanCorn","DisplayCategory","FoodN");
TweakItem("Base.BoxOfCanBeef","DisplayCategory","FoodN");
TweakItem("Base.BoxOfCanMushroomSoup","DisplayCategory","FoodN");
TweakItem("Base.BoxOfCanPeas","DisplayCategory","FoodN");
TweakItem("Base.BoxOfCanPotato","DisplayCategory","FoodN");
TweakItem("Base.BoxOfCanSardines","DisplayCategory","FoodN");
TweakItem("Base.BoxOfCanSoup","DisplayCategory","FoodN");
TweakItem("Base.BoxOfCanTomato","DisplayCategory","FoodN");
TweakItem("Base.BoxOfCanTuna","DisplayCategory","FoodN");
TweakItem("Base.BoxOfDogFood","DisplayCategory","FoodN");
TweakItem("Base.BoxOfCanPeaches","DisplayCategory","FoodN");
TweakItem("Base.BoxOfCanCocktail","DisplayCategory","FoodN");
TweakItem("Base.BoxOfCanPineapple","DisplayCategory","FoodN");
TweakItem("Base.BoxOfJamFruit","DisplayCategory","FoodN");
TweakItem("Base.BoxOfJamMarmalade","DisplayCategory","FoodN");

Traduction mod better sorting to Spanish of Spain

Hello! I am contacting you to tell you that I have translated your mod into Spanish of Spain. If you want the translation, I'll send it to you without any problem. I was going to use it for my own use, but I thought it was better to send it to you if you want it.
Greetings!^^

1.6.1 error + VFE_Items.lua update

After new update 1.6.1 in workshop many players got error:
[06-05-23 09:34:44.997] LOG : Lua , 1683354884997> Loading: D:/SteamLibrary/steamapps/workshop/content/108600/2313387159/mods/BetterSorting/media/lua/client/Mod Support/Fluffy_Items.lua.
[06-05-23 09:34:45.008] ERROR: General , 1683354885008> ExceptionLogger.logException> Exception thrown se.krka.kahlua.vm.KahluaException: Fluffy_Items.lua:87: '=' expected near <eof> at LexState.lexerror line:278..
[06-05-23 09:34:45.008] ERROR: General , 1683354885008> DebugLogStream.printException> Stack trace:.

Also there is 2 items from VFE that u haven't in configs: Base.9mmClip13 and Base.P229

TweakItem("Base.9mmClip13","DisplayCategory","WepAmmoMag");
TweakItem("Base.P229","DisplayCategory","WepFire");

Please add it and fix that error

Update V2.0.1 compatibility issues.

As of update V2.0.1 (it persists on V2.0.2) many items seem to be miscategorized and some categories appear to no longer exist.

Antibiotics, beverages, alcohols and condiments are now all set as "food - non-perishable", the same happened to bleach (lol), some items that before were categorized as "cooking" (pans and such) are now containers.

The screenshots on the other issue suggests that this issue doesn't affect this mod on it's own, since there are "Food - alcohol" items there and this category seems to no longer exist in my game, indicating that this is a compatibility problem with some other mod.

I can say with certainty that this was technically caused by update V2.0.1 since none of my other mods updated at the same date and nothing else changed.

As a side note - some of the new categories added in the update do exist ingame, like "clothing - arms/hands", so the update did apply.

I am aware that this might not be a problem that can be fixed by the developer of "Better Sorting" but I do want to let you know that compatibility issues now exist - I'm still trying to pinpoint what exactly is the other mod that is now causing it when in combination with this - but since steam discussion seems to be closed this is the only real way to report this.

PZ

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.