choria-legacy/go-client

Go client libraries for the Choria Orchestrator

go-client's Issues

use protocol filter helpers

choria-legacy/go-protocol#36

allow callers to specify a name to use for the NATS connection

without this long running programs that make many clients will produce huge amounts of prometheus metrics - 2 or 3 per client invocation

support multiple connections

At the moment when receivers are given it's only the user supplied handler that is run concurrently - multiple network connections are not used.

Instead make multiple network connections and multiplex across them

remove incorrect log dependency

We use github.com/apex/log by accident

support fire and forget requests

At present a handler has to be passed, it should support a nil handler that would not do any subscribes or process any returns

add helpers to create fact filters from cli strings

Something like:

pf, err := NewFilter(ClassFilter("klass"), AgentFilter("agent"), IdentityFilter("ident"), FactFilter("country=mt"))

add callbacks for publish start and end

should handle empty string filters

AgentFilter, ClassFilter, IdentityFilter, CompoundFilter, CombinedFilter and FactFilter should all gracefully handle empty strings as noop

broadcast discovery should create a timeout context used by the client

When doing discovery the supplied context is used verbatim:

https://github.com/choria-io/go-client/blob/3abc5542c103b7a2c1990c099097dc756c0de4dc/discovery/broadcast/broadcast.go#L85

This means that if the initial connection fails or whatever - it's going to be stuck here forever rather than discovery timeout period. Probably we need a initial connect timeout rather than a whole timeout over the entire discovery but for now lets just wrap the whole client request in a context and give it timeout+2

support go-srvcache and go-config

should fail immediately when transport creation failed

Error from publish is squashed here meaning it waits for timeout while doing nothing

https://github.com/choria-io/go-client/blob/6a493a64ba4011382339b37dc1ae0cd2fdfc2428/client/client.go#L128

use released go-choria with the needed changes

update for latest choria NewRequestID() API

See choria-io/go-choria#470