chrisbuchholz/accord

Data validation library for Rust

accord's Issues

Test on both stable and nightly

Integration with Rocket should be made simpler if possible

Right now, to integrate with Rocket one has to set up a few things, most notable is the FromData implementation that is needed. It can be seen here: https://github.com/ChrisBuchholz/accord/blob/master/examples/rocket/src/account.rs#L25-L38

If possible, one should be able to derive it or something since those 13 lines will be the same needed for every Type in your Rocket application that uses Accord.

Find a better way to use RangeInclusive

The patter used to implement length and range validators using RangeInclusive is ugly; especially the panic here: https://github.com/ChrisBuchholz/accord/blob/master/src/validators.rs#L74

Find a better way.

Makefile for testing accord + example crates

Right now, the only way to test both accord and its examples is to run cargo test in both the accord crate and the bundled example crates. Introducing a Makefile to handle testing could reduce this to a single stop of make test.

Closure validator

Explore possibility for better Rocket support

Being able to derive support for FromForm for Validated<T> where T: Accord + Validated and FromData would make Rocket integration much simpler.

Email validator

I'm really not sure about this, since it's easy to make an email validator too restrictive so as to hit false on obscure but valid urls.

More complete examples

The only real examples right now focuses of use in a REST API setting. There should be examples showcasing other scenarios.

Validators should be have better documentation and tests

Tests: there is not enough coverage

Range is supposed to be half-open

Range is defined in Rust as half-open: so 12..127 means “at least 12, and less than 127”. In your validators you’ve implemented it with incorrect semantics, treating it as an inclusive range, which is instead 12...127 (and experimental).

Auto-rules for structs?

If you're looking for an idea for something to do, I think it would be pretty cool if I could:

#[derive(AccordValidate)]
struct Account {
    #[accord_rule(length(1..64))]
    name: String,
    #[accord_rule(length(5..64), contains("@"), contains("."))]
    email: String,
    #[accord_rule(range(12..127))]
    age: i8,
}

And get an auto-impld Account::validate function. A similar thing like derive(AccordNew) or AccordBuilder seem like something that would also be nice so that it's impossible to even build invalid objects in the common case.

Codecov integration

Provide an API for stable rust

Currently there's no timeline for stabilization of impl trait. What do you think about moving the current validators behind a nightly feature gate, and returning boxed closures when that feature is not enabled?

URL validator

I'm really not sure about this, since it's easy to make an URL validator too restrictive so as to hit false on obscure but valid urls.

Regex validator