chrisdanford/grunt-ver

grunt-ver's Issues

References replacements have no concept of path

If you hash two files on different paths that have the same filename all references that get replaced will only use the same hash. For instance if you have MathJax in your path like:

vendor/js/MathJax/jax/input/AsciiMath/config.js
vendor/js/MathJax/jax/input/MathML/config.js
vendor/js/MathJax/jax/input/TeX/config.js
vendor/js/MathJax/jax/output/HTML-CSS/config.js
vendor/js/MathJax/jax/output/NativeMML/config.js
vendor/js/MathJax/jax/output/SVG/config.js

Then when you hash it you get something like:

vendor/js/MathJax/jax/output/SVG/config.02437fe5.js
vendor/js/MathJax/jax/output/HTML-CSS/config.5ada570d.js
vendor/js/MathJax/jax/output/NativeMML/config.53a6cc82.js
vendor/js/MathJax/jax/input/MathML/config.49dbdf64.js
vendor/js/MathJax/jax/input/TeX/config.5b950842.js
vendor/js/MathJax/jax/input/AsciiMath/config.20e7393e.js

So far so good, but when you look in a file that references one of those say vendor/js/MathJax/jax/input/MathML/config.49dbdf64.js for example, you'll find stuff like:

MathJax.InputJax.MathML.loadComplete("config.20e7393e.js");

Which should actually be:

MathJax.InputJax.MathML.loadComplete("config.49dbdf64.js");

Separating the processing into phases won't fix this, but separate tasks will. For a large project it can result in a lot of headaches.

Documentation uses the wrong task name

In README.md the examples all suggest making a task called version which Grunt will never find. Turns out the actual task is called ver. Can you update the docs to reflect this for lazy copy/pasters like myself who waste 10 mins on this?

versionFile not optional?

The versionFile parameter is marked as optional, but when I leave it out (or set its value to ''), it generates a warning and does not complete the versioning process :(

Since I really do not need the version file I would appreciate it if the parameter was truly optional, i.e. could simply be left out.

Grunt 0.4 Release

I'm posting this issue to let you know that we will be publishing Grunt 0.4 on Monday, February 18th.

If your plugin is not already Grunt 0.4 compatible, would you please consider updating it? For an overview of what's changed, please see our migration guide.

If you'd like to develop against the final version of Grunt before Monday, please specify "grunt": "0.4.0rc8" as a devDependency in your project. After Monday's release, you'll be able to use "grunt": "~0.4.0" to actually publish your plugin. If you depend on any plugins from the grunt-contrib series, please see our list of release candidates for compatible versions. All of these will be updated to final status when Grunt 0.4 is published.

Also, in an effort to reduce duplication of effort and fragmentation in the developer community, could you review the grunt-contrib series of plugins to see if any of your functionality overlaps significantly with them? Grunt-contrib is community maintained with 40+ contributors—we'd love to discuss any additions you'd like to make.

Finally, we're working on a new task format that doesn't depend on Grunt: it's called node-task. Once this is complete, there will be one more conversion, and then we'll never ask you to upgrade your plugins to support our changes again. Until that happens, thanks for bearing with us!

If you have any questions about how to proceed, please respond here, or join us in #grunt on irc.freenode.net.

Thanks, we really appreciate your work!

Any interest in making this support Grunt .4?

More a question than an issue, just curious if there was intent on making this support Grunt .4?

Hashing Is Inconsistent Because `hash` Should Accept A Buffer

In npm-0.11+ the hash.update(...) function must receive a buffer to create consistent and reliable hashes. Instead the current codebase is processing a String value instead of the Buffer.

I've made the change over in this fork but haven't created any unit test(s). I will be happy to get this pull request in ship-shape if this project is still being maintained. Cheers.