chrisnew/rts_pstor

Working linux driver for Realtek Semiconductor Co., Ltd. RTS5209 PCI Express Card Reader (rev 01)

rts_pstor's Issues

do_gettimeofday needs to be replaced

In file included from /var/lib/dkms/rts_pstor/1.11/build/xd.c:28:
/var/lib/dkms/rts_pstor/1.11/build/rtsx.h: In function ‘get_current_time’:
/var/lib/dkms/rts_pstor/1.11/build/rtsx.h:178:2: error: implicit declaration of function ‘do_gettimeofday’; did you mean ‘do_settimeofday64’? [-Werror=implicit-function-declaration]
  do_gettimeofday(&tv);
  ^~~~~~~~~~~~~~~
  do_settimeofday64

maybe it’s time to checkout linux/ktime.h

Build error on Ubuntu 22.04

1. instructions from the readme.md are incomplete for Ubuntu 22.04: you need to install flex and bison as well
2. Even then: build error, see below.

Output of DKMS make.log file:

DKMS make.log for rts_pstor-1.11 for kernel 6.2.0-39-generic (x86_64)
Sat Dec 16 11:25:43 CET 2023
sed "s/RTSX_MK_TIME/`date +%y.%m.%d.%H.%M`/" timestamp.in > timestamp.h
cp -f ./define.release ./define.h
make -C /lib/modules/6.2.0-39-generic/build/ SUBDIRS=/var/lib/dkms/rts_pstor/1.11/build modules
make[1]: warning: jobserver unavailable: using -j1.  Add '+' to parent make rule.
make[1]: Entering directory '/usr/src/linux-headers-6.2.0-39-generic'
  SYNC    include/config/auto.conf.cmd
  YACC    scripts/kconfig/parser.tab.[ch]
  HOSTCC  scripts/kconfig/lexer.lex.o
  HOSTCC  scripts/kconfig/menu.o
  HOSTCC  scripts/kconfig/parser.tab.o
  HOSTCC  scripts/kconfig/preprocess.o
  HOSTCC  scripts/kconfig/symbol.o
  HOSTCC  scripts/kconfig/util.o
  HOSTLD  scripts/kconfig/conf
make[1]: warning: jobserver unavailable: using -j1.  Add '+' to parent make rule.
make[2]: *** No rule to make target 'arch/x86/entry/syscalls/syscall_32.tbl', needed by 'arch/x86/include/generated/uapi/asm/unistd_32.h'.  Stop.
make[1]: *** [arch/x86/Makefile:248: archheaders] Error 2
make[1]: Leaving directory '/usr/src/linux-headers-6.2.0-39-generic'
make: *** [Makefile:39: default] Error 2
[hugo-ThinkPad-L390] /usr/src$ modprobe rts_pstor
modprobe: FATAL: Module rts_pstor not found in directory /lib/modules/6.2.0-39-generic

Any pointers appreciated!

Arch Linux AUR

Would make sense to have an AUR ready for this. :)

dkms needs to be run as root

Error when installing on Ubuntu 17.04

Hi,

I'm trying to install your driver on Ubuntu 17.04.
I got this following error:

In function ‘memcpy’,
    inlined from ‘inquiry’ at /var/lib/dkms/rts_pstor/1.11/build/rtsx_scsi.c:366:3,
    inlined from ‘rtsx_scsi_handler’ at /var/lib/dkms/rts_pstor/1.11/build/rtsx_scsi.c:3126:11:
./include/linux/string.h:305:4: error: call to ‘__read_overflow2’ declared with attribute error: detected read beyond size of object passed as 2nd parameter
    __read_overflow2();
    ^~~~~~~~~~~~~~~~~~
scripts/Makefile.build:302: recipe for target '/var/lib/dkms/rts_pstor/1.11/build/rtsx_scsi.o' failed
make[2]: *** [/var/lib/dkms/rts_pstor/1.11/build/rtsx_scsi.o] Error 1
Makefile:1546: recipe for target '_module_/var/lib/dkms/rts_pstor/1.11/build' failed
make[1]: *** [_module_/var/lib/dkms/rts_pstor/1.11/build] Error 2
make[1]: Leaving directory '/usr/src/linux-headers-4.13.0-17-generic'
Makefile:37: recipe for target 'default' failed
make: *** [default] Error 2

I am having the following issues building on Ubuntu 5.3.0-28-generic:

sed "s/RTSX_MK_TIME/date +%y.%m.%d.%H.%M/" timestamp.in > timestamp.h
cp -f ./define.release ./define.h
make -C /lib/modules/5.3.0-28-generic/build/ SUBDIRS=/home/fcavalcanti/Downloads/realteksdcarddriver/rts_pstor-1.11 modules
make[1]: Entering directory '/usr/src/linux-headers-5.3.0-28-generic'
Makefile:227: ================= WARNING ================
Makefile:228: 'SUBDIRS' will be removed after Linux 5.3
Makefile:229:
Makefile:230: If you are building an individual subdirectory
Makefile:231: in the kernel tree, you can do like this:
Makefile:232: $ make path/to/dir/you/want/to/build/
Makefile:233: (Do not forget the trailing slash)
Makefile:234:
Makefile:235: If you are building an external module,
Makefile:236: Please use 'M=' or 'KBUILD_EXTMOD' instead
Makefile:237: ==========================================
CC [M] /home/fcavalcanti/Downloads/realteksdcarddriver/rts_pstor-1.11/rtsx.o
In file included from /home/fcavalcanti/Downloads/realteksdcarddriver/rts_pstor-1.11/rtsx.c:28:0:
/home/fcavalcanti/Downloads/realteksdcarddriver/rts_pstor-1.11/rtsx.h: In function ‘get_current_time’:
/home/fcavalcanti/Downloads/realteksdcarddriver/rts_pstor-1.11/rtsx.h:178:2: error: implicit declaration of function ‘do_gettimeofday’; did you mean ‘do_settimeofday64’? [-Werror=implicit-function-declaration]
do_gettimeofday(&tv);
^~~~~~~~~~~~~~~
do_settimeofday64
In file included from /home/fcavalcanti/Downloads/realteksdcarddriver/rts_pstor-1.11/rtsx.c:29:0:
/home/fcavalcanti/Downloads/realteksdcarddriver/rts_pstor-1.11/rtsx_chip.h: At top level:
/home/fcavalcanti/Downloads/realteksdcarddriver/rts_pstor-1.11/rtsx_chip.h:330:0: warning: "SG_END" redefined
#define SG_END 0x02

In file included from ./include/linux/blkdev.h:28:0,
from /home/fcavalcanti/Downloads/realteksdcarddriver/rts_pstor-1.11/rtsx.c:23:
./include/linux/scatterlist.h:65:0: note: this is the location of the previous definition
#define SG_END 0x02UL

/home/fcavalcanti/Downloads/realteksdcarddriver/rts_pstor-1.11/rtsx.c:273:3: error: ‘struct scsi_host_template’ has no member named ‘use_clustering’
.use_clustering = 1,
^~~~~~~~~~~~~~
cc1: some warnings being treated as errors

Does not build on 5.10.0-5-amd64 on Debian bullseye/sid

hi,

the module can't build against 5.10.0-5-amd64:

1. I got :

sudo dkms install rts_pstor/1.11

Kernel preparation unnecessary for this kernel. Skipping...

Building module:
cleaning build area...(bad exit status: 2)
make -j4 KERNELRELEASE=5.10.0-5-amd64 KVERSION=5.10.0-5-amd64...(bad exit status: 2)
Error! Bad return status for module build on kernel: 5.10.0-5-amd64 (x86_64)
Consult /var/lib/dkms/rts_pstor/1.11/build/make.log for more information.

cat /var/lib/dkms/rts_pstor/1.11/build/make.log
DKMS make.log for rts_pstor-1.11 for kernel 5.10.0-5-amd64 (x86_64)
Mon Apr 12 11:46:50 CEST 2021
make: *** No targets specified and no makefile found. Stop.

I found the Informations:

================= WARNING ================
'SUBDIRS' will be removed after Linux 5.3

If you are building an individual subdirectory
in the kernel tree, you can do like this:
$ make path/to/dir/you/want/to/build/
(Do not forget the trailing slash)

If you are building an external module,
Please use 'M=' or 'KBUILD_EXTMOD' instead

So I try to change SUBDIRS with M after this I got the next error

2. Now I get:

DKMS make.log for rts_pstor-1.11 for kernel 5.10.0-5-amd64 (x86_64)
Mon Apr 12 11:51:17 CEST 2021
sed "s/RTSX_MK_TIME/date +%y.%m.%d.%H.%M/" timestamp.in > timestamp.h
cp -f ./define.release ./define.h
make -C /lib/modules/5.10.0-5-amd64/build/ M=/var/lib/dkms/rts_pstor/1.11/build modules
make[1]: warning: jobserver unavailable: using -j1. Add '+' to parent make rule.
make[1]: Entering directory '/usr/src/linux-headers-5.10.0-5-amd64'

ERROR: Kernel configuration is invalid.
include/generated/autoconf.h or include/config/auto.conf are missing.
Run 'make oldconfig && make prepare' on kernel src to fix it.

make[2]: *** [/usr/src/linux-headers-5.10.0-5-common/Makefile:717: include/config/auto.conf] Error 1
make[1]: *** [/usr/src/linux-headers-5.10.0-5-common/Makefile:185: __sub-make] Error 2
make[1]: Leaving directory '/usr/src/linux-headers-5.10.0-5-amd64'