christoomey/anchorlinks

Chrome extension for copying the anchored link to a web page

anchorlinks's Issues

Only count solitary Ctrl key presses

C-a C-e will currently trigger. Or C-f C-f

Additionally support anchor tags with name attribute

http://stackoverflow.com/questions/484719/html-anchors-with-name-or-id/484781#484781

So, it will look for id="foo" followed by name="foo"

Example link, from LYAH http://learnyouahaskell.com/starting-out#an-intro-to-lists

Icon updates

• Clean up the icon transparency
• Use base64 to inline it.
• Make sure inserting the links doesn't cause any scrolling of the window.

Failing on Rails blog

Despite expected formatting (id="foo" attribute), anchorlinks not finding anyting:

http://weblog.rubyonrails.org/2014/12/19/Rails-4-2-final/#maintenance-consequences-and-rails-50

Auto-enabling on flipboard blog

http://engineering.flipboard.com/2015/02/mobile-web/

Page loads with links targeted

Why?

Filter to only elements within viewport

Typical usage is to activate while viewing the element:

From this stack overflow answer

function isElementInViewport (el) {

    //special bonus for those using jQuery
    if (typeof jQuery === "function" && el instanceof jQuery) {
        el = el[0];
    }

    var rect = el.getBoundingClientRect();

    return (
        rect.top >= 0 &&
        rect.left >= 0 &&
        rect.bottom <= (window.innerHeight || document.documentElement.clientHeight) && /*or $(window).height() */
        rect.right <= (window.innerWidth || document.documentElement.clientWidth) /*or $(window).width() */
    );
}

Hotkey mechanism interfering with focus events

Seems to block focus events for inputs.

Failure / Not Found notification

Currently nothing is displayed if there are no matches. Would prefer to have some sort of notification to say that none were found (within current viewport)

Avoid false positives like highlighter nodes

Rails guides use highlighter that adds an ID. This is likely not the desired anchor, and more importantly, since it's injected after page load it won't work the majority of the time.

Unsure if it's possible to filter out these sorts of links. The only thing I can think of is the fact that they are added after the fact, but not even sure how to hook into that.

Sample from the rails routing guides

<div id="highlighter_138920" class="syntaxhighlighter nogutter  ruby">

Hotkeys for visible links

The mouse is the worst! This will register a hotkey for each of the visible (viewport, not page) links. Should be able to go through the whole process without touching the mouse.