christopher-dg/go-obs-websocket

Go client for obs-websocket

go-obs-websocket's Issues

panics if OBS is killed..

I handled OBS event Exiting and then disconnects properly.

But if OBS is killed, after 1000 iteration, the Client.poll() panics.

Furthermore, according to Gorilla websocket overview and Conn.NextReader() documentation:

Applications must break out of the application's read loop when this method
returns a non-nil error value. Errors returned from this method are
permanent. Once this method returns a non-nil error, all subsequent calls to
this method return the same error.

I propose to fix this by checking if the returned error is *CloseError then we Disconnect the client.. If you are okay with the fix, I will send a pull request..

Updated bindings

It would be nice to have updated bindings to support newly implemented API functionality. Could you also document how you generated the sources, because I can't quite figure out how codegen/protocol.py is meant to be called.

Thank you!

JSON nested objects not correctly encoded / parsed

It looks like nested objects in JSON aren't correctly encoded or parsed:

position.x or position.alignment will always be 0 because that's not the correct JSON key. The key is alignment inside the position struct.

More idiomatic generated code

Stuff like this is really gross:

go-obs-websocket/requests_streaming.go

Lines 246 to 256 in 2efc360

	func NewStartStreamingRequest(
	stream map[string]interface{},
	streamType string,
	streamMetadata map[string]interface{},
	streamSettings map[string]interface{},
	streamSettingsServer string,
	streamSettingsKey string,
	streamSettingsUseAuth bool,
	streamSettingsUsername string,
	streamSettingsPassword string,
	) StartStreamingRequest {

Implementing something along these lines would be much nicer. Maybe it's also time to look at using go generate, since the Python script is pretty unwieldy.