christophery/good-share

Good Share is a share button library with Web Share API integration.

good-share's Issues

Not working in Samsung Internet (as in-app browser)

The web share API doesn't officially work in Samsung Internet browser but it should trigger the fallback share.

But when using the Samsung Internet browser as a in-app browser, the share buttons do nothing...not even the fallback share opens.

Steps to reproduce

1. Set Samsung Internet browser as default browser.
2. Email the Good Share demo link to yourself.
3. Open the link using the in-app browser (I used Gmail).

Notes/Thoughts

• It seems like the navigator.share feature detection is broken in Samsung Internet (in-app).
• Works fine if page is viewed directly in the browser (not in-app)
• Works fine using Firefox or Chrome (in-app and not-in-app)
• Might be related to this Chromium issue

Lost param in in app browser: Facebook in app browser...

I have a case:
button share have param like [domain.com]/share?catid=1&product=2
in Chrome is ok
BUT
in facebook in app, when click share button, param ?catid=1&product=2 will lost, link on facebook only have [domain.com]/share?
Please check and we will fix.
I think we should encodeURI component

Encode special characters

Need to encode special characters in the share title, description and URL.

Can use encodeURI() and/or encodeURIComponent() functions