Using requires instead of imports prevents from prerendering

[chrisvfritz]

Using requires instead of imports prevents from prerendering

[toverux]

I've also had that ReferenceError: Can't find variable: Promise error, I've fixed it (before seeing this issue) by adding core-js' Promise polyfill in my app.

import 'core-js/es6/promise';

@chrisvfritz are you saying that I shouldn't do that just to support Phantom?

[alanaasmaa]

@drewlustro Manually editing this file like this has fixed the same issue for me on 3 PC's.

85d7d8c

[chrisvfritz]

I haven't encountered this. A minimal example reproducing the problem will definitely help! 🙂

[chrisvfritz]

The 2.0 release was just pushed out, so it's also worth testing that the problem still occurs.

[nimser]

Sounds great. I'm away from keyboard until mid-january. Will definitely check then.

[u12206050]

I might also have this issue even on V2.0, I have the following code where I am using require

Vue.component('login', function (resolve) {
  require(['./login.vue'], resolve)
})

this is so I can lazy load the login component.

The code works, but prerender doesn't generate any prerendered html on any of my paths, in fact when ever I have another route besides '/' that I want prerender, the build just never stops without any warnings or errors even after waiting for more than 30 minutes.

After removing the require statement I get the following error on build:

node_modules/prerender-spa-plugin/lib/compile-to-html.js:80
                    if (error) throw stdout
                               ^
WARNING: JavaScript error while prerendering: /
ReferenceError: Can't find variable: Promise

  phantomjs://code/phantom-page-render.js:26 in onError

[chrisvfritz]

@u12206050 I think you're getting a different problem. We use core-js to polyfill Promise and other features, but in your case, Promise is undefined when your script runs. 😕 I'll try to look into this soon.

[u12206050]

@chrisvfritz Thanks, have you been able to find out anything? I know that the use of vue-material is currently limiting my chances of getting any sort of prerendering working.

[lyquocnam]

is this fixed ? i tried like @toverux but it still not work @@

[drewlustro]

Hello @lyquocnam ! Could you please provide code to reproduce your issue?

[drewlustro]

Are you all including a Promise polyfill in your own code?

[drewlustro]

@alanaasmaa thanks for the info! 👍

[drewlustro]

@niwolive @u12206050 @lyquocnam @alanaasmaa – this has been fixed in #54, which was merged in last week and published on npm.

Cheers.