chrisviral/comp-345

COMP 345 Fall '17 project

comp-345's Issues

Player reinforce/attack/fortify methods should not be static

https://github.com/StupidChris/COMP-345/blob/9336f55b6bcd08305602933082453dd4a81dd876/Comp345_Risk/Player/Player.h#L26-L37

Map data structure

We might have to double check with the prof to see if we are allowed to use a hash map instead of a graph. I feel like it might be a requirement in the project to add some complexity to it.

Creates the wrong number of players

https://github.com/StupidChris/COMP-345/blob/25d4f2297eaa21e2a50a8d09885d81acc89fbacf/Comp345_Risk/Game/GameStart.cpp#L59

Inserting the size of of a vector, and then pushing to the back, doubles the vector size, because it just pushes at the end.

I fixed this before the demo. We just have to remember to fix for A3

Potential deleting map issue

https://github.com/StupidChris/COMP-345/blob/5ffce13973201f6f35a40593e542f8764ec3219d/Comp345_Risk/Game/Game.cpp#L19

You have to be careful here. You have to figure out which object should own that pointer. Since you are passing the pointer from a parent object, either that parent object should delete the map or the Game object, but not both. Lets say the main driver creates the map, but then pass the pointer to the game object, should the main driver delete the map, or the game object?

Usually the initial creator of the object should own and delete it. The way you did it works, but it is something to think about. A good rule of thumb is that when other objects use another pointer owned by an object, you should pass const pointers, so that the non owner of that pointer cant modify the the pointer address, though they can still modify the object that the pointer is passing to.

Tldr; Figure out which object should delete the map. And only delete once.