chrisxu/cxphotobrowser

Photo browser for iOS, Inspiring by @MWPhotoBrowser. Supporting with high level customization, including Navigationbar, Toolbar, Loading process placeholder and Loading failure placeholder.

Hi there 👋

I'm a software engineer who has been building beautiful iOS apps since 2011. I am also passionate about helping other engineers and shaping a healthier engineering culture.

• 🧑‍💻 I code in Swift by day, Python by night, and JS on weekend.
• 📚 I like reading books. Here is my booklist.
• 📝 Occasionally, I write my thoughts on Write The Func.
• ⭐️ Fun fact: The only novel I have is The Hitchhiker's Guide to the Galaxy

cxphotobrowser's Issues

browserNavigationBarViewOfPhotoBrowser not called

i followed the usage and implemented datasource methods, both required and optional,especially the browserNavigationBarViewOfPhotoBrowser method.

the result is the image is shown correctly, but the nav bar not showed.

edit: i've tryed to change the way browser shown from pushViewController to presentViewController, and it works.

it's a issue or a feature?

Pull request

Did you consider trying to submit your changes back upstream as a pull request?

Is there anyway to get current image directly?

when CXPhotobrowser is presented, Is there an easyway to get current image directly?

wifi connection

I want to allow users to download photos from internet only when wifi is connected. How to do it?

CXPhotoLoading need to change init param

In CXPhotoLoading.h, you init with param CXPhoto. So that, if user need to implement their CXPhoto (with CXProtocol), then they get a warning. I think it should better if you change your init like this (in both .h and .m)

- (id)initWithPhoto:(id<CXPhotoProtocol>)photo;

P/S: Your libs is the best flexible Photo Browser I researched in CocoaControl (IDMPhotoBrowser, MWPhotoBrowser...). Thank you for your hard work in this project! :)

Suggestion for delegate

Isn't it CXPhotoBrowserDelegate a better place for these 2 methods?

• (CXBrowserNavBarView *)browserNavigationBarViewOfOfPhotoBrowser:(CXPhotoBrowser *)photoBrowser withSize:(CGSize)size;
• (CXBrowserToolBarView *)browserToolBarViewOfPhotoBrowser:(CXPhotoBrowser *)photoBrowser withSize:(CGSize)size;

kinwah

some problem when using "setInitialPageIndex"

CXPhotoBrowser really help me a lot,but when I using "setInitialPageIndex",there has a problem,the browser just show up the hint"sorry! unable to load image",it looks like the browser didn't load the pic on initial index ever.

a small photo is not fill the screen's width

a small photo is not fill the screen's width,

Changing the color of the status bar

Where in the code should I change the settings to color the status bar did not change after viewing full-screen images (double tap)?

init by Storyboard

I decide to use your CXPhotoBrowser in storyboard but can't handle it. The reason is you don't implement method [initWithCoder:]. I changed your implement file like this. Hope you can consider it.

- (id)init
{
    self = [super init];
    if (self)
    {
        [self setupDefault];
    }
    return self;
}

- (id)initWithCoder:(NSCoder *)aDecoder
{
    self = [super initWithCoder:aDecoder];
    if (self)
    {
        [self setupDefault];
    }
    return self;
}

- (void)setupDefault
{
    self.wantsFullScreenLayout = YES;
    self.hidesBottomBarWhenPushed = YES;
    _performingLayout = NO; // Reset on view did appear
    _rotating = NO;
    _viewIsActive = NO;
    _scrolling = NO;
    _didSavePreviousStateOfNavBar = NO;
    _shouldUseDefaultUINavigationBar = NO;
    _supportReload = YES;
    _photoCount = NSNotFound;
    _currentPageIndex = 0;
    _visiblePages = [[NSMutableSet alloc] init];
    _recycledPages = [[NSMutableSet alloc] init];
    _photos = [[NSMutableArray alloc] init];

    [[NSNotificationCenter defaultCenter] addObserver:self
                                             selector:@selector(handleCXPhotoImageDidStartLoad:)
                                                 name:NFCXPhotoImageDidStartLoad
                                               object:nil];

    [[NSNotificationCenter defaultCenter] addObserver:self
                                             selector:@selector(handleCXPhotoImageDidFinishLoad:)
                                                 name:NFCXPhotoImageDidFinishLoad
                                               object:nil];

    [[NSNotificationCenter defaultCenter] addObserver:self
                                             selector:@selector(handleCXPhotoImageDidFailLoadWithError:)
                                                 name:NFCXPhotoImageDidFailLoadWithError
                                               object:nil];

    [[NSNotificationCenter defaultCenter] addObserver:self
                                             selector:@selector(handleCXPhotoImageDidStartReload:)
                                                 name:NFCXPhotoImageDidStartReload
                                               object:nil];
}

library not found for -lPods

When i run you are demo project i received following error

ld: library not found for -lPods
clang: error: linker command failed with exit code 1 (use -v to see invocation)

When scrolling through the images sometimes gets stuck.

It's stuck while listing full screen "Portrait" photos!

get photo with index

Some 3rd lib (like iCarousel) give user some method to work item (current item, selected item...). I see that you have some methods in CXPhotoBrowser.m but they're private methods.

// Data
- (id<CXPhotoProtocol>)photoAtIndex:(NSUInteger)index;
- (NSUInteger)indexOfPhoto:(id<CXPhotoProtocol>)photo;