chronodave/doombox

Music player for your unwieldy music collection

doombox's Issues

Add `theme.borders()` function on Theme

ImageSelect path does not resolve on Mac

Integrate PouchDB into Electron for plug-and-play support

• Research sync capabilities of PouchDB for off-site database storage

Add reducer pattern to store lib

Finish up ModalCreateProfile

• Make FieldSelectAvatar more accessible by means of IconButtons
• Hook up FE with BE

Move complex components to `modules` folder in src

• Sidebar
• Settings

Add RTL support

Add 'already have a profile?' button on FormCreateProfile

User should be able to connect to their remote on FormCreateProfile

• Add FormReadRemote:
  • Url field
  • Username field (if secured)
  • Password field (if secured)

Add 3rd party audio source support

• YouTube
• Internet Radio

Implement image manipulation

https://www.npmjs.com/package/jimp

Missing flag on FieldLanguage

Add lossless string compression for ID's

ID's are currently saved as paths. These can be pretty long and should be compressed to save space

Replace react-router-dom with custom router

The DOM doesn't get used, and native doesn't work well on desktop. A custom router can be written quite easily with a provider-like HOC

Fix delete user racing

Currently the connection get severed on PENDING_DELETE_USER, which should be done on SUCCESS_DELETE_USER (when the user is actually deleted).

The connection and user should be split into two separate events, CONNECTION and USER.

ID3 parser

Fix corrupted images

Seems to be a size limit. Possibly related to #12 ?

Code-splitting

• Split up Mongoose models into the following schema:

modules
 - [module_name]
   - models
   - resolvers
   - schemas
   - validation

Shuffle function should never return original array

Shuffle function should reshuffle in the case that the shuffled array is equal to the original array

Create test files

Most scanning issues are related to corrupt metadata and don't give feedback to the user.

Some examples:

• Image extensions (jpg vs JPG, image/jpeg vs jpeg)
• Multiple images
• Illegal url characters
• No metadata at all
• Corrupted frame ID's
• Frame sizes with negative length

Finish up SidebarItemUser

• Add Profile to the SidebarItemUser
• Add link to Settings

Local file paths not working on Mac

Local files get accessed from localhost:5000 on development. Adding file:// fixes the issue

Add back-end mappers

Reduce data send to front-end by using mapper functions on back-end

Implement loading screen

Implement a loading screen for database connection

Translate language select to native language

PouchDB stuck in loop when creating profile

#22 Seems to resolve when error is clicked away

Occurs on every PouchDB related action

Add language coverage script

Write CLI tool that compares locale scripts.

• Inform user which key is missing in which file
• Inform this by language
• Automatically scan all locales, no manual work
• Sort keys alphabetically before scanning
• (Optional) https://github.com/badges/shields/tree/master/gh-badges

Add profile statistics

• Most- / least-played
• Total time since installed
• Amount of shuffles
• Favorite playlist
• Favorite song
• Favorite album
• Favorite label

Replace action helper functions with a single action function

actionPending(actionCreate(LIBRARY)) => action(PENDING, CREATE, LIBRARY)

Write tests

What about tap: https://node-tap.org/

• Write functional tests for components (enzyme?)
• Write functional tests for Electron
• Write end-to-end tests for pages (cypress?)

Profile customization

A user should be able to:

• Change the interface language
• Set custom colors
• Enable / disable notifications
• Custom key shortcuts with cheatsheet
• Change their connections
• Change their background
• Change their profile
• Set layout to RTL and vice-versa

Module vs component

Several components / modules are open for discussion:

• Modal (component) => module
• Settings (module) => module, but different structure

Router not correctly redirecting

Doombox/packages/doombox-react/src/components/App/App.jsx

Line 50 in d2c0916

<HashRouter>

<Switch /> only takes direct route components. Remove fragments

Refactor database class

• Errors aren't consistent
• Syntax isn't consistent
• Add readOneFromId (as id-only query is quite common)
• Look into update, what does docs param do
• Add jsdoc

Create library views

• Label View
• Album View
• Song View
• Playlist(s) View

Background image not loading correctly on build package

UnhandledPromiseRejectionWarning: RangeError: Invalid typed array length: -1

 (node:10428) UnhandledPromiseRejectionWarning: RangeError: Invalid typed array length: -1
    at new Uint8Array (<anonymous>)
    at decodeFrame (D:\Assets\Works\Projects\[ARC-016] Doombox\Doombox\packages\doombox-electron\src\lib\parser\decode.js:78:7)
    at D:\Assets\Works\Projects\[ARC-016] Doombox\Doombox\packages\doombox-electron\src\lib\parser\index.js:41:21
    at FSReqCallback.readFileAfterClose [as oncomplete] (internal/fs/read_file_context.js:61:3)
(node:10428) UnhandledPromiseRejectionWarning: RangeError: Invalid typed array length: -1
    at new Uint8Array (<anonymous>)
    at decodeFrame (D:\Assets\Works\Projects\[ARC-016] Doombox\Doombox\packages\doombox-electron\src\lib\parser\decode.js:78:7)
    at D:\Assets\Works\Projects\[ARC-016] Doombox\Doombox\packages\doombox-electron\src\lib\parser\index.js:41:21
    at FSReqCallback.readFileAfterClose [as oncomplete] (internal/fs/read_file_context.js:61:3)
(node:10428) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:10428) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:10428) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
(node:10428) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Create listener factory

Instead of manually creating listeners for every event type, create a function that generates these automatically.

// asyncType, crudType, type
const generateSubscriber = args => ipcMain.on(action(...args)

Create error views

• RemoteUserError
  • Edit & validate connection
  • Go offline
  • Try again
• UserError
• OfflineError

Test .zip scanning

• Check if .zip files are valid directories
• Check how speed compares to regular directories

Replace PouchDB with NeDB

• Fetch cached user
• Create new user
• Update user
• Create image
• Fetch image
• Create library
• Fetch library
• Update library

Add wiki

• Explain how Doombox works
• Explain how to sync up with remote MongoDB
• Explain where to find error logs
• Explain how to integrate 3rd party sources

htmlFor should use same id as defined in input

Doombox/packages/doombox-react/src/components/Field/FieldFile/FieldFileBase.jsx

Line 55 in d2c0916

htmlFor={`select-${name}`}

Add back-end validation

Make sure data from the front-end is valid by validating the data before it's inserted into the database.

Research Amazon AWS S3 as off-site storage solution

Remove `getAlpha` function, replace with `fade`

Input not resetting when selecting same file again

Doombox/packages/doombox-react/src/components/Field/FieldFile/FieldFileBase.jsx

Line 26 in d2c0916

Add input.value = null to fix

Fix image data not displaying on mediaSession

Images are too big, rescale to 128x128 (for Windows).

Add error handler

• Use errorTypes to define errors, similar structure to asyncActionTypes
• Error object should contain it's type and message.
• Message is a localization string
• Errors should be graded on severity
• Severe / unexecpted errors should be wrriten to appData/errors and have timestamp as filename

Text not wrapping correctly on long title string

Refactor ModalScanning

ModalScanning can be optimized further by minifying the ModalData components, ideally to a singular component.