chrs1885/sheetycolors

An action sheet styled color picker for iOS.

sheetycolors's Issues

Support Swift Package Manager

What kind of feature would you like to see?

iOS 13 comes with SPM support which can be used to manage your app's dependencies. SheetyColors should provide support for it as well.

Wrong Hex value displayed after entering Hex code (HSB color space)

When entering specific Hex values (e.g. #ABCDEF) into the HSB color picker, it will set a different value. The problem is that SheetyColors will fall back to the nearest color that can be represented with integer values only.

If a user explicitly enters a color with a Hex value, we need to support float values as well.

Missing import when adding lib via SPM

Version 1.2.0 is missing some UIKit imports, which will cause build issues when intgrating the library via swift package manager.

HEX-Color input field

What kind of feature would you like to see?

Currently, the only way to create a color is by using the slider controls. To do so, you have to know the color values for RGB(HSB/Grayscale in advance. That being said, it's pretty much impossible to create a color by its HEX value.

How does it work in detail?

Provide a hex input field inside the preview color view.

What does the API look like?

Perhaps, we need to extend the public config to enable/disable the input field.

Any existing projects that do something similiar?

cant install

error: Unable to find a specification for SheetyColors

Material Action Sheet

Please fill out all lines starting with a 📝 when filing a feature request to give us an idea of what exactly went wrong.

What kind of feature would you like to see?

📝Would be great if we can use this cool colour picker inside a Material Action Sheet by Google.
And using Material Sliders.

How does it work in detail?

📝

What does the API look like?

📝https://material.io/develop/ios/components/action-sheet/
https://material.io/develop/ios/components/sliders/

Any existing projects that do something similiar?

📝Not that I'm aware of.

Add custom action sheet extensions (iOS 13 Support)

As a result of #3

What kind of feature would you like to see?

Add extensions to make SheetyColors work with other alert view libs. This way devs can add iOS 13 support by choosing any custom alert view for displaying the picker.

How does it work in detail?

Add extensions to wrap the SheetyColorsView inside the custom alert view controller.

What does the API look like?

Same as the existing API

Any existing projects that do something similiar?

Expose SheetyColors view

What kind of feature would you like to see?

In order to use SheetyColors within custom view containers (e.g. custom action sheet, SwiftUI views), we need access to the view representing the color picker.

How does it work in detail?

Make SheetyColorsViewController public.

What does the API look like?

Any existing projects that do something similiar?

Dark Mode Support

What kind of feature would you like to see?

Add support for Dark Mode (iOS 13)

How does it work in detail?

Change colors based on current dark mode status.

What does the API look like?

Any existing projects that do something similiar?

Delegate not called when hex value changed (custom container)

What did you do?

I was trying to enter a new hex value, however the delegate function didSelectColor doesn't get called.

What did you expect to happen?

The delegate function gets called once I enter a new hex value.

What happened instead?

The delegate function didn't get called.

Setup

The SheetyColors picker is wrapped by a custom view controller.

Breaking layout constraints when using picker inside of a custom container

What did you do?

I was trying to present the picker view controller modally (custom view container).

What did you expect to happen?

The view gets properly displayed without any warnings.

What happened instead?

I got warnings about breaking layout constraints. It seems like the preview color view has a fixed height, therefore I need to provide the exact height for the color picker to work around this issue.

Setup

Add message label

What kind of feature would you like to see?

While regular action sheet controllers do support a message, SheetyColors doesn't. Make this one an optional field of the configuration.

How does it work in detail?

Specify the message property inside the config protocol and display the value inside the view.

What does the API look like?

Add the message property to the protocol.

Any existing projects that do something similiar?

iOS 13 not working

What did you do?

I was testing my app on iOS 13 beta 4

What did you expect to happen?

I expected it work as it does on iOS 12

What happened instead?

The color section and sliders were all gray

Make sliders more accurate

What kind of feature would you like to see?

When end dragging RGB sliders on a real device, the targeted color value sometimes changed. Lifting off the finger seems to change the slider position.

How does it work in detail?

This could be solved by either doing some fancy zoom animation (depending on dragging speed) or by making right assumptions about the targeted color value.

What does the API look like?

Any existing projects that do something similiar?