Allow the calling script to pass additional DIC parameters

[cilex]

Allow the calling script to pass additional DIC parameters

[simensen]

Silex allows this but it looks like it does not pass the values to the constructor. Instead it processes them manually. I imagine this is because Silex sets up some default services and if parent::__construct($values) was used the Silex added services would always override the user contributed services and properties.

https://github.com/fabpot/Silex/blob/master/src/Silex/Application.php#L147-L149

I would recommend we do something similar. Allow for passing the $values array but process them ourselves at the bottom of the constructor instead of passing them to parent::__construct.

/cc @pulse00

[pulse00]

I like the way Silex handles the initialization of services,

1. They initialize the DIC with defaults
2. They allow user to pass in initial services to Pimple
3. The passed services will override any default services.

I think Cilex should follow this pattern, by simply adding the defaults values array to the constructor and initializing the DIC using the constructor argument after all the defaults have been set.

This would not introduce any BC breaks.

[simensen]

Yep. To clarify, I think this is what we are talking about:

public function __construct($name, $version = null, array $values = array())
{
    parent::__construct();
    $consoleConfig = array('console.name' => $name);
    if (null !== $version) {
        $consoleConfig['console.version'] = $version;
    }
    $this->register(new ConsoleServiceProvider(), $consoleConfig);
    foreach ($values as $key => $value) {
        $this[$key] = $value;
    }
}

[mvriel]

Fixed in master at commit c6ebee2