citizenos/ep_embedded_hyperlinks2

Etherpad plugin to embed hyperlinks within a pad

ep_embedded_hyperlinks2's Issues

[Feature Request] Open Link dialog box

Description

If you know klick on a link, you don't know where it's directing to.

Possible solution

(1) Provide an dialog box which asks you if you want to continue to the following link or not (as for example Telegram does if you go on a link).

(2) Show an box with the address of the hyperlink if you go with the cursor on the link.

Thanks for your help! King regards, Flo

Dialog does not open with Etherpad 1.8.4

I just installed Etherpad Version 1.8.4 with ep-embedded_hyperlinks2 version 1.2.2 and though hyperlinks created with Etherpad version 1.8.0 are still shown as Links, the dialog box doesn't open when the Hyperlink icon is clicked.

Css & install 1.1.3

From @revast:

How would I get 1.1.3? via the plugin manager? I alterd index.js by hand for now

I also have these minor issues (with the css, it seems??):

The button is a bit lower then the others
Underlying text is to be shown underneath the OK button (propably also because of this offset)

npm page links to disfunct url

https://www.npmjs.com/package/ep_embedded_hyperlinks2

has sebballot in its links, which obviously does not work...

locales folder

Please add a locales folder to enable translations.

Thank you

[Feature request] Unlink portion of linked text

When selecting something that's a link, have a button show up in toolbar to unlink that portion of linked text.

PS this looks dope!

Ep_embed_hyperlink2 1.22 for etherpad 1.9

Hi,

After upgrading hyperlink2 to the latest version, we get this error message:
Ep_embed_hyperlink2: Please upgrade to etherpad 1.9 for this plugin to work correctly

Etherpad is currently at version 1.8.3 which makes hyperlink2 unusable.

[Bug] Copy/cut+paste corrupts embedded hyperlinks

Hey, this plugin could be super useful for the collaborative work in pads, but it still comes along with some problems... Copying/cutting links still destroys them which compromises the editing somethow :/

System

OS: Win 8.1 and 10
Browser: Firefox 76 / Chrome 81 / Microsoft Edge Version 81.0.416.72
Etherpad Version: 1.8.4

Example / Steps to reproduce

Embed a hyperlink (e.g. https://tuuwi.de) to the an arbitrary word (here "tuuwi").

In general, the behaviour equals for Copy (Ctrl+C/right click) and Cut (Ctrl+X/right click) and applies in the same way for copying within the same pad as well as from one pad to another (in the same browser).

Firefox

Authorship color not cleared

The pasted embedded hyperlink still appears as link but becomes unclickable (nothing happens on click). Copying this again with authorship color cleared opens in http://www.url-,.com/

Authorship color cleared

The pasted embedded hyperlink opens in http://www.url-https.com//tuuwi.de,https://tuuwi.de and not in https://tuuwi.de as expected.

Behaviour resambles when copying from firefox to chrome/edge.

Chrome and Microsoft Edge

The embedded hyperlink is pasted as plain text (independently whether authorship color is cleared or not). Behaviour resambles when copying from chrome/Edge to firefox.

---

Would be really cool if that was fixed! :) Thank you very much for your commitment!

Feature Request: Simplify linking to another pad

I used to make heavy use of ep_linkify, which I can not find online to add back to my system.

If the code for the default protocol in ep_embedded_hyperlinks2 is modified slightly, users could create links to another pad simply by typing the filename portion of the pad's URL (that is, the pad name with illegal characters converted to underscores).

Proposed change:

56  - url = "http://" + url;
56  + url = window.location.origin + "/p/" + url;

Now if I want to link to another pad on my server, I simply paste the pad name into the 'URL' field (and replace spaces etc with underscores)

create frontend tests..

[Bug] Copy embedded hyperlink doesn't work

Description

When I create a single hyperlink in a line and copy it to the next line, it's gone. When I wrap some text arround, it still works, but the link is corrupted. Furthermore, it's not possible to copy the link by selecting the text somehow.

Would be really cool if you could fix that! :) Thank you very much for your commitment!

Preserve links on export/import

All links are lost when exporting to html or any other format. Also, it would be great to restore them during import of saved document.
I am absulute dummy in node and js, but looking at the export code I noticed that there is some hook which enables including extra tags into exported html, so this must not be extremely complicated to do.
Regards,
Vasyl

open the current url

Click on the hyperlink set before， sometimes it will open the current page(http://localhost:9001/p/xxx)