This project forked from friedger/stacks-send-many
Basic UI components for interacting with the CityCoin contract. Requires Stacks Wallet for Web.
Home Page: https://minecitycoins.com
License: GNU General Public License v3.0
This is a nice to have, or maybe a V2 thought:
It would be great if someone mining/stacking a CityCoin could turn around and Stack their STX from the same screen. A basic flow for delegated Stacking similar to that of the desktop wallet would make sense.
It also could tie into the pool registry contract, similar to:
https://stacks-pool-registry.pages.dev/
https://github.com/friedger/stacks-pool-registry
Describe the bug
When trying to claim tokens at a specific block height through the function claim-stacking-reward in the contract, the transaction succeeds but then is rolled back by a post-condition.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Both STX and CityCoins should have transferred to my wallet.
Additional Context
Relevant contract code below:
(define-public (claim-stacking-reward (target-reward-cycle uint))
(let (
(stacker tx-sender)
(entitled-ustx (get-entitled-stacking-reward tx-sender target-reward-cycle block-height))
(stacked-in-cycle (get-stacked-in-cycle tx-sender target-reward-cycle))
)
(begin
(asserts! (> entitled-ustx u0)
(err ERR-NOTHING-TO-REDEEM))
(map-set stacked-per-cycle
{ stacker: tx-sender, reward-cycle: target-reward-cycle }
{ amount-token: u0 })
(try! (as-contract (stx-transfer? entitled-ustx tx-sender stacker)))
(try! (as-contract (ft-transfer? citycoins stacked-in-cycle tx-sender stacker)))
(ok true)
))
)
Noting that there are some differences in the token code between the version deployed to testnet and the most recent code in the citycoins repo.
Noticed this after submitting my register tx:
Make it easy for users to get from $MIA --> $STX --> $BTC by providing basic instructions and resources about Stacking STX.
Add average commits for the last 5, 30, 100, 300 blocks to give a better sense of how much is required to mine.
Describe the bug
Using target="_blank" without rel="noreferrer" is a security risk: see https://html.spec.whatwg.org/multipage/links.html#link-type-noopener
Describe the bug
When calling mine-many with entries of 0.001 the post condition shows 0 STX as post condition
I love jdenticons, but I am worried the user will not realize what this is and be distracted by it.
It'd be easier to just use a small STX logo since it's next to a STX address anyway.
Describe the bug
The way we compute and show the stacking claims now, there are two issues:
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The card to claim the tokens should only show for the last reward cycle tokens are stacked for, e.g.
The claim button should be disabled if the reward cycle is active, and we could add a badge or some sort of "in progress" notification.
Screenshots
note that alternate layout above is from #54
Clicking on a TX ID leads me to the explorer in the same window, and this would be better in a separate tab.
For state management across components, use jotai https://github.com/pmndrs/jotai
Right now there is placeholder code for a "last 5 transactions" section in the full profile.
This should be in its own component and load the data dynamically.
Error after logout, probably related to small profile implementation in header next to nav, need to dig further.
Unhandled Rejection (TypeError): Cannot read property 'appPrivateKey' of null
(anonymous function)
src/lib/hooks.js:14
11 | useEffect(() => {
12 | if (userSession) {
13 | getUserData(userSession).then(userData => {
> 14 | const { address } = getStacksAccount(userData.appPrivateKey);
| ^ 15 | setAppStxAddress(addressToString(address));
16 | setOwnerStxAddress(userData.profile.stxAddress[testnet || mocknet ? 'testnet' : 'mainnet']);
17 | });
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Maybe something like "Get started with a decentralized Stacks Account" or something like that (if I wasn't expecting a pop up I might be a bit confused - any context here might help!)
Describe the bug
Can't 'View address on explorer' after logging in to 'https://minecitycoins.com'
To Reproduce
Steps to reproduce the behavior:
Expected behavior
View my address in explorer
Screenshots
Desktop (please complete the following information):
Additional context
Tried this after logging in with wallet SP2T04RQY3SP5V24233ABVX9G5CV14NMSB1ZF83NQ
Sometimes, instead of the word 'profile', it has part of my address, but most of the time it just says 'profile', am I really logged in?
The main website uses the citycoin blue logo reversed, we should match that.
Under claim mining rewards I saw that I won a block (or at least I think I did?):
I then tried claiming it using the displayed block height, tx confirmed here:
After refreshing now I see the same message and it's not easy to tell if I should claim for that height again or not.
If we could update it to be a button per claim like the screenshot below, it would prevent users from having to enter the block number, and also make it easier to see if a reward was claimed or not.
Is your feature request related to a problem? Please describe.
As part of citycoins/contracts#102, the function get-tokens-in-cycle is replaced by get-tokens-per-cycle, which returns an optional tuple instead of a uint.
Describe the solution you'd like
The UI should use get-tokens-per-cycle and process the data accordingly.
When I press the "Get Started" button, I get the following error if my extension is disabled:
TypeError: Object(...) is not a function
showConnect
http://localhost:3000/static/js/vendors~main.chunk.js:21716:82
handleOpenAuth
src/lib/auth.js:35
32 | };
33 |
34 | const handleOpenAuth = () => {
> 35 | showConnect(authOptions);
| ^ 36 | };
37 |
38 | const handleSignOut = useCallback(() => {
Need to test if this is the same for if someone doesn't have the extension installed, and handle the error appropriately.
After stacking all CC the balance is shown as 0. There should be information that the CC are stacked.
A few things that would be helpful:
When leaving the page open with mining/stacking instructions, this error eventually pops up:
Unhandled Rejection (TypeError): Cannot read property 'data' of undefined
getWinningDetailsFor
src/lib/citycoin.js:155
152 | const minerOfBlockCV = hexToCV(minerOfBlock.data);
153 | console.log({ minerOfBlockCV: cvToString(minerOfBlockCV) });
154 | // add commit to total
> 155 | const nextSum = sum + minerOfBlockCV.value.data.ustx.value.toNumber();
| ^ 156 | // check total for winning amount
157 | if (sum <= winningAmount && nextSum > winningAmount) {
158 | winner = minerOfBlockCV;
View compiled
async getMiningDetails
src/lib/citycoin.js:105
102 | for (let tx of txs) {
103 | if (tx.contract_call.function_name === 'mine-tokens-over-30-blocks') {
104 | for (let i = 29; i >= 0; i--) {
> 105 | winningDetails.push(await getWinningDetailsFor(tx.block_height + i, minerId));
| ^ 106 | }
107 | } else {
108 | winningDetails.push(await getWinningDetailsFor(tx.block_height, minerId));
It should be easier to see what you are going to spend when checking this box, which is basically 30x the amount specified.
In the confirmation window values were displayed in STX, and it's a bit confusing, e.g.
Bidding 10 uSTX = 0.00001 STX
Total Bid = 0.0003 STX
Some useful info for the mining claim tab:
I added an input for memo, but it's not connected to the underlying functions so its disabled for now.
Miners can submit an (optional) memo with each transaction, and we should enable that!
Each tab could show the relevant transactions, making it easier to understand what's been done in each context.
register-minermine-blocks and mine-over-30-blocksclaim-token-rewardstack-tokensclaim-stacking-rewardIs your feature request related to a problem? Please describe.
Linking citycoins/contracts#98 and citycoins/contracts#101 here since this will affect the next deloyment.
Describe the solution you'd like
Any UI functions that use claim-token-reward will need to be updated to claim-mining-reward.
Is it interesting whether mining rewards have been claimed?
Not sure how much of a change this would be, but definitely something to look at if it's going to be a template moving forward.
The small profile component loads a larger offcanvas tab for the full profile component.
After first login, the data on this element is not updated until the page is refreshed one time. It should update based on the login action.
(also ties in to #32)
Note: initial value is undefined based on the View on Explorer button
Initial list of criteria based on PRD below:
General UI flow outlined here:
https://miro.com/app/board/o9J_lGTdbbg=/?moveToWidget=3074457358599766193&cot=14
Right now it's just a placeholder, it should have the address shown on the profile tab when logged in.
As we add more info things are starting to feel cluttered, and we should revisit the layout of content.
Now that we have pox-lite info, we are looking at what stats would be useful to miners in #13, and as more items come up, I think it makes sense to separate things out into pages:
I will look at this against the original Miro drawing in #7 and draft up a wireframe before we go too deep into it. Since we have a good grid system with bootstrap there's probably a better way to lay it out then just the side by side with profile + info cards anyway.
Recording my thoughts here for now, more to come!
Describe the solution you'd like
We should add a link to the testnet faucet when connected to testnet.
Right now I wired up the dashboard to show PoX stats from the contract as well as an activity log (thanks to @friedger adding the CityCoinTxList component).
The layout is a little messy, and it should be easier to read and understand what information is being presented.
Are there other things we should display here? What is most useful to the user?
Should the information be split into relevant tabs, e.g. mining stats like #13 displayed on the mining tab?
The "Learn More" button could link out to docs... simply a lot to first dive into for someone who might stumble upon this!
There is a delay between meeting the number of required signalling miner and the actual mining. (100 blocks)
The UI should show when mining is available.
Claiming block rewards one by one is annoying.
The accordion used to display the activity log is broken.
The naming for each item uses the same IDs for each entry, so they all expand/contract at the same time.
In the CityCoinTxList component, the key used for iterating over the blockHeights array should set the following values for each component it creates, rather than just reuse the same One for all:
<h2 class="accordion-header" id="accordionActivityLog-headingOne">
data-bs-target="#accordionActivityLog-activityOne"
aria-controls="accordionActivityLog-activityOne"
id="accordionActivityLog-activityOne"
aria-labelledby="accordionActivityLog-headingOne"
As part of #31 I added number-to-words as a dependency, which should make it easy to take the key and convert it into the relevant IDs and values. e.g. below:
import converter from 'number-to-words';
converter.toWords(13); // => “thirteen”
Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
Add any other context about the problem here.
The label is misleading, needs an update!
Once bids get larger then STX may be more relevant ?
The text "City Coin is not activated" should disappear after mining registration is complete.
Given Stacks Wallet for Web doesn't work on mobile without some interesting tricks, we should present users with a splash screen that tells them mining/stacking should be done from the desktop.
There is a button for signing out, but it doesn't do anything yet!
Describe the solution you'd like
We should add a link to the contract deployment, maybe in the profile?
Now lives at a new location on CDN, needs an update!
Lost blocks are shown as empty lines or as claimed (was claimed by other miner)
Three things that would be helpful from the mining tab, open to more ideas as well!
Current stx committed is shown as 0 even though miners send stx.
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
Django
The Web framework for perfectionists with deadlines.
Laravel
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft
Open source projects and samples from Microsoft.
Google
Google ❤️ Open Source for everyone.
Alibaba
Alibaba Open Source for everyone
D3
Data-Driven Documents codes.
Tencent
China tencent open source team.
