Giter Site home page Giter Site logo

SX1262 support about lora_device_lib HOT 4 CLOSED

cjhdev avatar cjhdev commented on July 18, 2024
SX1262 support

from lora_device_lib.

Comments (4)

cjhdev avatar cjhdev commented on July 18, 2024 2

I'm gonna be using an STM32l431, so not a problem for me! I'll test the module on arduino before possibly porting the arduino wrapper to STM32duino.

I like Arduino wrappers. Aside from being easy to use, they are a good chance to sanity check the interfaces and portability features. I'd like to have more of them.

Just a side note, but I personally don't really like gitflow's develop and master split

I've actually never used it. A policy of "use a tagged release" is much simpler.

PR may never materialize.

No worries.

from lora_device_lib.

cjhdev avatar cjhdev commented on July 18, 2024

The new radios look great, I would be very happy to accept code to support them.

For contributing a radio driver I think the guidelines to observe are:

  • must be contributed with the same license (it's still your code, of course)
  • must have an opt-in build option (e.g. LDL_ENABLE_SX1262)
  • must be selectable at run-time (like the existing radio drivers)
  • must keep consistent style (mainly concerned about indentation and spaces)

Hopefully the run-time selection feature doesn't cause too many problems. It was easy with the SX1272/6 since it's almost the same chip. I like it because it will make it possible have universal wrappers on Arduino style platforms that have plenty of flash.

I am interested to see if the existing Mac->Radio interfaces make sense for a new type of radio. They can be modified if necessary.

I'm not currently using any well thought out branching strategy. Assume that I will accept a pull-request to master if it passes review. If people start depending on this library I might shift to something like gitflow to stage releases.

Word of warning, I'm about to commit a bunch of interface changes to master. A lot of it is silly stuff like making the prefixes consistent (no more mixed lora/ldl). There is a slight change to how the Radio interrupt lines connect back to the MAC. Once this is done I hope it can remain stable for a long time.

from lora_device_lib.

RX14 avatar RX14 commented on July 18, 2024

The guidelines are sane, and what I would have done anyway :)

Arduino style platforms that have plenty of flash

I'm gonna be using an STM32l431, so not a problem for me! I'll test the module on arduino before possibly porting the arduino wrapper to STM32duino.

I'm not currently using any well thought out branching strategy. Assume that I will accept a pull-request to master if it passes review. If people start depending on this library I might shift to something like gitflow to stage releases.

Just a side note, but I personally don't really like gitflow's develop and master split - releases should use git tags and development should happen on master.

Word of warning, I'm about to commit a bunch of interface changes to master. A lot of it is silly stuff like making the prefixes consistent (no more mixed lora/ldl). There is a slight change to how the Radio interrupt lines connect back to the MAC. Once this is done I hope it can remain stable for a long time.

Thanks for the heads up! I'm not likely to start working on this until the module works it's way to me from China, and even then I'm quite busy working on a cubesat, so this PR may never materialize.

from lora_device_lib.

cjhdev avatar cjhdev commented on July 18, 2024

0.5.0 supports SX1262 🎉

from lora_device_lib.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.