Giter Site home page Giter Site logo

Comments (4)

rdhainaut avatar rdhainaut commented on May 26, 2024 1

The project is cool and it s under MIT licence.
So first thank you for your work.

The documentation is well but it miss something to prevent surprise.
I will be honest without the last paragraph, I would never have found the solution.
But It is not obvious that build optimizations can "break" your dependencies injection wrapper.
When something looks like broken in PRODUCTION is always a bad surprise.

For me, in your readme file you should :

  1. Add a note inside 'How to use' section that says the lib could not work if it s using optimization builder (with a link to last paragraph). It will prevent any bad surprise.
  2. Add a note inside 'How to configure Terser' that say vue-cli use Terser plugin under the hood (and should be configurer via vue.conf.js)

Edit: I will do the PR with the link as suggested

from inversify-props.

rdhainaut avatar rdhainaut commented on May 26, 2024

Note: after add the above configure webpack option it s working in production too ! 👍

from inversify-props.

CKGrafico avatar CKGrafico commented on May 26, 2024

Hello and thanks for your issue, is not enough with the docs? https://github.com/CKGrafico/inversify-props#how-to-configure-uglify-or-terser. If not, you can create a PR with a link to this issue :)

from inversify-props.

CKGrafico avatar CKGrafico commented on May 26, 2024

Feedback is always appreciated!

from inversify-props.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.