Comments (4)
The project is cool and it s under MIT licence.
So first thank you for your work.
The documentation is well but it miss something to prevent surprise.
I will be honest without the last paragraph, I would never have found the solution.
But It is not obvious that build optimizations can "break" your dependencies injection wrapper.
When something looks like broken in PRODUCTION is always a bad surprise.
For me, in your readme file you should :
- Add a note inside 'How to use' section that says the lib could not work if it s using optimization builder (with a link to last paragraph). It will prevent any bad surprise.
- Add a note inside 'How to configure Terser' that say vue-cli use Terser plugin under the hood (and should be configurer via vue.conf.js)
Edit: I will do the PR with the link as suggested
from inversify-props.
Note: after add the above configure webpack option it s working in production too !
from inversify-props.
Hello and thanks for your issue, is not enough with the docs? https://github.com/CKGrafico/inversify-props#how-to-configure-uglify-or-terser. If not, you can create a PR with a link to this issue :)
from inversify-props.
Feedback is always appreciated!
from inversify-props.
Related Issues (20)
- How can I use this library using my own inversify container? HOT 4
- Error with Vue in production. HOT 7
- Named injections do not work HOT 1
- *bug* cid :: Not clearing cached Symbol, when renamed all interfaces names. HOT 7
- *bug* IE 11 Not supported :: HOT 1
- 2.0.1 is not working HOT 9
- Error when I use generics HOT 1
- [question]Difference between inversify-props and inversify-inject-decorators HOT 2
- Error: No matching bindings found for serviceIdentifier: Symbol() HOT 7
- Use descriptor in decorator HOT 1
- Inject decorator doesn't work in javascript HOT 3
- [Question] Is there a way to pass parameters to a concrete type when registering? HOT 3
- Singleton scope doesn't seem to work HOT 3
- Uncaught Error: @inject called with undefined this could mean that the class undefined has a circular dependency problem HOT 3
- Vue-CLI Production Error HOT 7
- Injecting Vue Component HOT 1
- Injecting into injectable doesn't seem to work HOT 1
- Doesn't work with Vite HOT 1
- [Question] How to use Jest HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from inversify-props.