Giter Site home page Giter Site logo

Comments (7)

dirodriguezm avatar dirodriguezm commented on May 26, 2024 1

@CKGrafico Ok, thanks. Right now I'm on a short holiday. I'll get back to it next week and might create a sandbox for yout to test.

from inversify-props.

CKGrafico avatar CKGrafico commented on May 26, 2024 1

That means you're minifiying the code without:

  keep_classnames: true,
              keep_fnames: true,

these options are only to don't have Symbol(I)

from inversify-props.

dirodriguezm avatar dirodriguezm commented on May 26, 2024 1

I created a project from scratch and worked totally fine. I also tried to match the dependencies from the working and not working projects but no luck. I guess I will have to not use minimizer or try with another instead of Terser.

from inversify-props.

CKGrafico avatar CKGrafico commented on May 26, 2024

Something is wrong in your config, is not working when you're doing the minification, I'll need a sandobx project to test

from inversify-props.

dirodriguezm avatar dirodriguezm commented on May 26, 2024

Hi again !

I tried to recreate the problem starting from a clean project but it worked fine. I'm sure there's a problem with my project, but unfortunately I can't make a sandbox with it. I can report back some progress though.

After carefully checking my tsconfig.json and refactoring a few classes I got to a point where I'm absolutely sure that there is a problem with bindings when running in production mode that does not happen on dev.

For example, there's a Vuex action that gets an instance from the container like this:

login() {
  const interactor = container.get<UseCaseInteractor>(cid.Login)
  interactor.execute()
}

Which results in the following error: Uncaught (in promise) Error: No matching bindings found for serviceIdentifier: Symbol(I)

In the part that I inject all dependencies I have this:

export function containerBuilder(): void {
  container.addSingleton<UseCaseInteractor>(Login);
}

This works fine on development mode but not when I build the project.

I'm using vue cli. On development mode I use vue-cli-service serve and for production I'm running vue-cli-service build.

from inversify-props.

dirodriguezm avatar dirodriguezm commented on May 26, 2024

@CKGrafico Ok, so I changed the webpack config inside my vue.config.js like this:

  configureWebpack: (config) => {
    config.optimization = {
      minimize: false, // <--- changed this to false
      minimizer: [
        new TerserPlugin({
          terserOptions: {
            keep_classnames: true,
            keep_fnames: true,
          },
        }),
      ],
    };
  },

Setting minimize option to false and got it working, so that's great. But what does this mean really ?
Is this the default or am I changing something that should not be changed ?
I thought that for the minimizer property to work I should have minimize set to true

Edit: vue inspect shows the following optimization options:

  optimization: {
    minimize: true,
    minimizer: [
      {
        options: {
          test: /\.m?js(\?.*)?$/i,
          chunkFilter: () => true,
          warningsFilter: () => true,
          extractComments: true,
          sourceMap: undefined,
          cache: true,
          cacheKeys: defaultCacheKeys => defaultCacheKeys,
          parallel: true,
          include: undefined,
          exclude: undefined,
          minify: undefined,
          terserOptions: {
            keep_classnames: true,
            keep_fnames: true
          }
        }
      }
    ]
  },

Printing the options on build step also shows correct value for keep_classnames and keep_fnames. What could be causing the error even if the setup is correct for minimizer ?

from inversify-props.

CKGrafico avatar CKGrafico commented on May 26, 2024

No idea, never happened to me, if you create a project form scratch is also happening? if you use another minimizer instead Terser is also happening?

from inversify-props.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.