Giter Site home page Giter Site logo

Comments (4)

clarkbw avatar clarkbw commented on May 25, 2024

If it is just a case of missing support, I think we can add it. If you want I can make a PR to add these mocks, I looked over the existing source code and I think I understand how this library works.

Yes, please do! I'd love a PR to add support. 🔨

from jest-webextension-mock.

pureooze avatar pureooze commented on May 25, 2024

I made the mocks for the windows api (see here) but I just had a question about how jest-webextension-mock works 🤔 .

In the documentation for the chrome.tab.get API the callback is passed a Tab object. But when I look in the mocks I see:
export const tabs = { get: jest.fn((id = '', cb = () => {}) => cb({})), ... }

So I have two questions:

  1. If the code being tested actually passes in a callback it will expect a Tab object with certain properties but from what I can tell it will always get an empty object?
  2. How does this deal with the difference between the browser.* and chrome.* APIs? From what I understand the WebExtension API expects promises while the chrome API expects callbacks. So if I understand this correctly if we call browser.tabs.get in our code we wont have anything returned?

from jest-webextension-mock.

clarkbw avatar clarkbw commented on May 25, 2024

If the code being tested actually passes in a callback it will expect a Tab object with certain properties but from what I can tell it will always get an empty object?

I'm guessing you'll need to fix that and it was just stubbed out.

How does this deal with the difference between the browser.* and chrome.* APIs? From what I understand the WebExtension API expects promises while the chrome API expects callbacks. So if I understand this correctly if we call browser.tabs.get in our code we wont have anything returned?

In a number of places where this is a concern we use a pattern like this:

const getDetails = (details, cb) => {
if (cb !== undefined) {
return cb();
}
return Promise.resolve();
};

from jest-webextension-mock.

ronilitman avatar ronilitman commented on May 25, 2024

Any progress on this? :)

from jest-webextension-mock.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.