clashkinginc/clashkingbot

An Open Source Clash Of Clans Bot aiming to cover all possible features & do the heavy lifting so others don’t have to.

ClashKing

Clashking

Clash of Clans family management bot for roles, player info, rankings, leaderboards, and more!
Explore the docs »

View Demo · Report Bug · Request Feature

ClashKing

An Open Source Clash of Clans Discord Bot pushing the boundaries of what is possible!

Built With

• Python 3.11
• coc.py
• disnake
• MongoDB
• Redis
• Other Packages

Sister Repositories

• ClashKing API
• ClashKing Tracking
• ClashKing Docs

Contributing

If you have a suggestion that would make this better, please fork the repo and create a pull request.
Don't forget to give the project a star! Thanks again!

License

Distributed under the MIT License. See LICENSE for more information.

Contact

Discord: Demo & Support Server

clashkingbot's Issues

clan warchannel edit - command

Enhancement Note: Add Townhall check for Clan Games and Raid Weekend message

Hello there,
I just wanted to point out that in the Clan Games and Raid Weekend messages, townhalls are included that are not able to participate.
If it is possible to fix this it would be much appreciated, but i understand that if you dont have this data already cached the additional requests could exceed the api limit of supercell and make this not so easy to implement.

Have a great day,
Andre

refactor .rank for speed

issues not entirely known, but should be able to reduce api/db calls to once, increasing speed

test

on_join messages - add multi-server support

trim requirements.txt file

only include pertinent package requirements

getClan - tidy link button

getClan - server info

addition of server info - channels, war ping status, roles to getClan

Switch troop emojis to square icons

https://github.com/MagicTheDev/ClashKing/blob/9cae40b55ed3d978de77339726a099e5a664a006/Dictionaries/emojiDictionary.py#L2-L111

Use square icons as seen in game, can be found here -> https://coc.guide/troop

Trophy Emojis - move to dictionary

switch trophy emojis from if statements to dictionary

Refactor Rosters

Rosters works, but can be made faster w/ tweaks to reduce api/db calls

Move "troop methods" to the CustomPlayer Class

https://github.com/MagicTheDev/ClashKing/blob/9cae40b55ed3d978de77339726a099e5a664a006/utils/troop_methods.py#L1-L261

Move & integrate the troop methods in question to the CustomPlayer class here: https://github.com/MagicTheDev/ClashKing/blob/9cae40b55ed3d978de77339726a099e5a664a006/CustomClasses/CustomPlayer.py#L19
goal: improve reuse, remove unnecessary imports

• Move troop methods
• fix naming convention to be pythonic, is currently camel case
• clean code (remove unnecessary loops, comments, etc)
• fix dependent code

Simplify & Enhance Welcome Messages

https://github.com/MagicTheDev/ClashKing/blob/9cae40b55ed3d978de77339726a099e5a664a006/Setups/welcome_messages.py#L20-L119

Instead of the very bulky , hard to manage, & non-customizable welcome-messages currently
Let users create custom one, using - > https://autocode.com/tools/discord/embed-builder/
The output as js, so will have to edit it a bit to get json

• Convert previous welcome messages to a format compatible with this

Command flow:

• Run Command
• Message Explaining where to create the code for the custom message
• Explain in message, that if non-link buttons are created, they will have no functionality (for now)
• Explain how to create a link to a discord channel (the functionality of the current buttons)
• Buttons - one to open a modal to paste the code, second with link to the embed builder
• Upon completion show what the embed looks like

getClan - sort by trophies button

emoji string to partial emoji method

create an emoji strong to partial method, kinda chunky, increase readability/ease when we have to create it

First Image Missing in /linkhelp Embed

The image URL here is broken, so the screenshot showing where to find the player tag does not appear in the /linkhelp command.

remove hardcoded emoji strings

.top autoboard - add more sizings

allow more size options for .top autoboard - default 50

Button Pagination- Cleanup

Move button pagination into own class, import for use throughout

Issue Templates

create issue templates to add structure and uniformity to issues

• labels
• bug template
• feature template
• wording change template
• new command

Discord invitation link expired

The discord invitation link expired, can you update it?

change default clan channel - Command

clan defaultRole edit - Command

War loss of 0 is automatically set to 1

https://github.com/MagicTheDev/MagicBot/blob/7f2bd517593467800ef5c16a2a52ab8f6c47d78c/Clan/ClanResponder.py#L39

@MagicTheDev, it seems as though when a clan's war loss is 0 you have it changed to a war loss of one.

Seems like an easy fix, but I figured I would check, why is this?

Reorganize Cogs

Reorganize Cogs, floders & names, will be important for auto help command

UnboundLocalError: local variable 'clan' referenced before assignment

https://github.com/MagicTheDev/MagicBot/blob/59d2d06c605ae9d1e22cca2fdf5788e71178f327/Family_and_Clans/strikes.py#L187-L288

Role & Hierarchy Permissions Check - Bot

https://github.com/MagicTheDev/ClashKing/blob/9cae40b55ed3d978de77339726a099e5a664a006/Link%20%26%20Eval/eval.py#L19-L26
Check that for every role that the bot may eval - it is valid & that the bot is above it & that the bot has Manage Role perms

release version setup

set up release versioning to track changes

Restructure Clan/Server Collections in DB

https://github.com/MagicTheDev/ClashKing/blob/9cae40b55ed3d978de77339726a099e5a664a006/CustomClasses/CustomBot.py#L93-L109

Currently Structure looks something like
DB - > Clan
DB - > Server
DB - > Server Feature (i.e Welcome Messages)

Needs to be changed to the following, to make making a Server Class & interactions with the DB easier
DB -> Server Collection -> clan fields, server feature fields
like - >
{
server_id : 0,
clans: [{
name : demo
tag: #2pp
}],
welcome_message : example
}

• database restructure
• change name of new db to not be "usafam"
• code changed across bot to work with new db

ValueError Utility.profile in game_rank

Just needs to be returned if the linked_accounts list is empty.

https://github.com/MagicTheDev/MagicBot/blob/dc6779cac7284054fe00a9a79842c5d00b4bb7fa/Utility/profile.py#L369-L370

clan leaderrole edit - command

Automated help command

help command that auto populates based on commands in cogs

New server join message.

Send a message when joining a new guild for the first time. The message should include buttons to join the help server, docs and mention the help command and how to setup clans.

The following code needs to be modified and a database entry needs to be added so the first time join message isn't sent everytime (this might change).
https://github.com/MagicTheDev/MagicBot/blob/2678f1c1a555c5e8426d6f1f4401ae5f5b0fcf72/discord_events.py#L91-L116

(Suggestion) Report Missed Attacks at End of War.

Similar to the bot that sends a reminder/notification about an hour before the end of the war about who still has attack(s) left, how about a bot that will send a report of who missed their attack(s) at the end of the war. Either automatically or by command. This could help keep track of members that constantly miss attacks and help War Generals.

Allow user to change their own nickname, regardless of permissions

https://github.com/MagicTheDev/ClashKing/blob/9cae40b55ed3d978de77339726a099e5a664a006/Link%20%26%20Eval/eval.py#L53-L59

prune unnecessary branches

essentially update the repo to make sure the remote repo is up to date and all branches are either in use, in dev, or deleted