claytondaley/drf-keyed-list

A reference implementation for converting a list of objects into a dict where the key is a (unique) value from the object (e.g. {<id1>: {<object1>}, <id2>: {<object2>}... }

drf-keyed-list's Issues

Exception if keys are UUID

I noticed this problem during applying the solution: if the key is UUID then the response dict is populated as UUID values which are not allowed in json.dumps function.
Python3 produces this exceptions:

.../3.7/lib/python3.7/json/encoder.py", line 257, in iterencode
    return _iterencode(o, 0)
TypeError: keys must be str, int, float, bool or None, not UUID

Python2 produces this:

.../2.7/lib/python2.7/json/encoder.py", line 270, in iterencode
    return _iterencode(o, 0)
TypeError: keys must be a string

I do not know what should we do here. Either we should convert all not supported values to str or maybe leave this on to being handled by custom JsonEncoder?!

Got error: 'KeyedListSerializer' is not defined

I follow the example in docs, and get error:
name 'KeyedListSerializer' is not defined

Could you please give an instruction, how to use this library?

great job ! I can't believe i found something taht should be a classic yet written just less than a month ago

Thanks for the great work!

AttributeError: 'list' object has no attribute 'items'

Oops, I think something is probs broken. I am using python 3.7 and django 2.15.

Following prescription, I am just doing this:
a = UserSerializer(User.objects.all(), many=True).data

Traceback (most recent call last):
  File "<input>", line 1, in <module>
  File "C:\Users\e\.virtualenvs\pinx-atTbH4Fl\lib\site-packages\rest_framework\serializers.py", line 765, in data
    ret = super(ListSerializer, self).data
  File "C:\Users\e\.virtualenvs\pinx-atTbH4Fl\lib\site-packages\rest_framework\serializers.py", line 262, in data
    self._data = self.to_representation(self.instance)
  File "C:\Users\e\.virtualenvs\pinx-atTbH4Fl\lib\site-packages\drf_keyed_list\serializers.py", line 19, in to_representation
    return {v.pop(self._keyed_field): v for k, v in response.items()}
AttributeError: 'list' object has no attribute 'items'

It seems that .items() is a dict method however the serializer is returning a list. I think it's a minor problem, but just haven't figure out how to modify the code...