cleancoders/cleancodecasestudy

Clean Code Case Study

cleancodecasestudy's Issues

Dependency Rule: UseCase depends on the ViewModel

The OutputBoundaries depend on their respective ViewModels.
As a result the UseCase component will also depend on the ViewModel, though it doesn't really need to.

What are some acceptable remedies here?
So far I see:

1. Change the return type of OutputBoundary#getViewModel() to the generic Object, use unit tests on the Presenter to satisfy doubts.
2. Add an empty ViewModelInterface for each UseCase component to be depended on by the OutputBoundary, UseCaseInteractor and the Controller while the Presenter uses the implementation directly.
3. Make a single empty ViewModel interface (set as immutable/sealed if possible) to be referred to in all the UseCase component. All ViewModels implement that interface and the rest is as above in # 2.

Main, line 37, sends the raw HTML without begin wrapped in HTTP protocol, returns error in modern Chrome

This page isn’t working
localhost sent an invalid response.
ERR_INVALID_HTTP_RESPONSE

Not sure if you want a PR for this series as it would have to apply to all the commits. :)

Setup guide for project

update README.md with instructions to run fitnesse and unit tests from IntelliJ IDE

Would be a time saver for those of us who would have to figure out how to follow the screencast without the required tools already in our back pocket.

ViewTemplate.create(String) uses non-portable code to read template file, fails on Windows

Exception in thread "pool-1-thread-2" java.nio.file.InvalidPathException: Illegal char <:> at index 2: /C:/Users/Brad/Projects/CleanCodeCaseStudy/target/test-classes/html/frontpage.html at java.base/sun.nio.fs.WindowsPathParser.normalize(WindowsPathParser.java:182) at java.base/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:153) at java.base/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:77) at java.base/sun.nio.fs.WindowsPath.parse(WindowsPath.java:92) at java.base/sun.nio.fs.WindowsFileSystem.getPath(WindowsFileSystem.java:229) at java.base/java.nio.file.Path.of(Path.java:147) at java.base/java.nio.file.Paths.get(Paths.java:69) at cleancoderscom.view.ViewTemplate.create(ViewTemplate.java:13) at cleancoderscom.usecases.codecastSummaries.CodecastSummariesViewImpl.toHTML(CodecastSummariesViewImpl.java:13) at cleancoderscom.usecases.codecastSummaries.CodecastSummariesViewImpl.generateView(CodecastSummariesViewImpl.java:42) at cleancoderscom.usecases.codecastSummaries.CodecastSummariesController.handle(CodecastSummariesController.java:24) at cleancoderscom.http.Router.route(Router.java:20) at cleancoderscom.utilities.Main.lambda$main$0(Main.java:35) at cleancoderscom.socketserver.SocketServer$1$1.run(SocketServer.java:33) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) at java.base/java.lang.Thread.run(Thread.java:834)

Not sure if you want a PR for this as it would have to apply to all the commits all the way down. :)

Dependency Rule is Violated

@unclebob Is it not true that all the arrows should point inward?

In this codebase, I see that CodecastDetailsUseCase (in package cleancoderscom.usecases) imports cleancoderscom.Context, which in turn imports cleancoderscom.gateways.CodecastGateway (from package cleancoderscom.gateways).

Therefore, doesn't the Use Case layer import from the Gateway layer, which violates the dependency rule?