cleverness/widget-css-classes

WordPress Plugin to add CSS classes to Widgets

widget-css-classes's Issues

Enhancement: Add filters to change capability access per form input type

Default capability: edit_theme_options
Option to change for

• ID
• Classes (input)
• Classes (select - predefined) >> If the user cannot access this then the input type should also be disabled

Feature Request

Hi, I'd like to be able to import widget class settings via theme level.

Can you provide an example of how this might be done and still allow the user to modify the settings? Would you recommend attaching this to after_theme_setup? Thanks!

update_option( 'WCSSC_options', $options );

[FEATURE REQUEST] - Class Groups

Predefined widget class groups / radio buttons.

I have a set of classes that affect different CSS properties, and would like them to be grouped since they are mutually exclusive:
Group 1 ( text color )

• text-color--gray
• text-color--white
• text-color--black

Group 2 ( background color )

• background-color--gray
• background-color--white
• background-color--black

Group 3 ( text alignment )

• align--left
• align--right
• align--center

It would be great to have 2 additional features with predefined classes:

1. Specify Groups
2. Specify radio buttons ( or select )

If I could define Groups in my $theme_classes array like so:

add_filter( 'widget_css_classes_set_settings', 'mytheme_css_classes_default_settings' );
function mytheme_css_classes_default_settings( $settings ) {
    $theme_classes = [
        'group_1' => [
      	  'background-color--gray', 
    	  'background-color--white',
    	  'background-color--black',
        ],
      'group_2' => [
    	'text-color--gray',
    	'text-color--white',
    	'text-color--black', 
      ],
      'group_3' => [
    	'align--left', 
    	'align--right', 
    	'align--center'
      ],
    ];

    // Append your classes.
    $settings['defined_classes'] = array_merge( $settings['defined_classes'], $theme_classes );

    // Or Prepend your classes.
    $settings['defined_classes'] = array_merge( $theme_classes, $settings['defined_classes'] );

    // Allways remove possible duplicates
    $settings['defined_classes'] = array_unique( $settings['defined_classes'] );

    // And return modified settings array
    return $settings;
}

Then on the Widget form, the options within each group would be converted to an array of radio buttons ( or select options ). This would help prevent users from setting more than one background color, etc. They would be able to set 1 background color, 1 text color, 1 alignment, and not have to worry about setting conflicting styles ( which could have unpredictable results ).

A further enhancement could be to add titles to each group:

    $theme_classes = [
        'group_1' => [
          'title' => "Background Color",
          "styles" => [
        	  'background-color--gray', 
        	  'background-color--white',
                  'background-color--black',
           ],
        ],
     ];

And to make it even nicer for users, the classes themselves could be given labels:

    $theme_classes = [
        'group_1' => [
          'title' => "Background Color",
          "styles" => [
        	  'background-color--gray' => 'Gray', 
        	  'background-color--white' => 'White,
                  'background-color--black' => 'Black',
           ],
        ],
     ];

I think this would be a kick ass addition. This feature could even be exposed in the UI.

Fix widget form div CSS: clear both

Related: https://wordpress.org/support/topic/consider-wrapping-in-div-with-clear-both/
Add clear: both;

Not working in Storefront Mega Menu widgets

The plugin is not working when I add widgets in Storefront Mega Menu but works with the widgets in the sidebar.

Compatibility: WP External Links

Pulled from: https://wordpress.org/support/topic/not-showing-predefined-classes-conflict-with-wp-external-links/

Option to remove duplicates

Currently the classes are simply prepended to the class attribute with a preg_replace.
I've created a method in my order (similar) plugin that can handle duplicates and both qouble and single quotes.
See: https://github.com/JoryHogeveen/genesis-widget-column-classes/blob/1.2.2/genesis-widget-column-classes.php#L389-L458

Lets patch it over along with it's unit tests!

Fix Widget Logic compatibility

When using the widget_content filter option the Widget Logic compatibility isn't working anymore.

Conflict with one setting in dFactory Repsonsive Lightbox plugin

Expected Behavior

Custom classes can be added to widgets.

Actual Behavior

Custom classes (text or predefined) do not get written out to html, but are displayed in Widget UI. Even custom widget css classes built into theme no longer work. The standard ones do get written out to html successfully (widget-first, widget-last, etc)

Steps to Reproduce the Problem

1. Install dFactory Responsive Lightbox plugin v 1.7.2 ( https://wordpress.org/plugins/responsive-lightbox/ )
2. Goto Plugin Settings, and General Settings tab
3. Select either "PrettyPhoto" or "Featherlight" as Default Lightbox (only tested with these two and the paid "Lightcase" that I purchased)
4. Check the box (enable) for "Widgets : Enable lightbox for widgets content."
5. Click Save at bottom.
6. Clear browser cache, and reload site to see issue.
7. Tried deactivating and deleting Widget CSS Classes and reinstalling, but issue persisted.
8. Disabled Repsonsive Lightbox setting for widget contents to resolve.

Notes

• I use a page caching plugin, but cleared cache for all test steps.

Specifications

• Plugin Version: 1.5.2.1
• WordPress Version: 4.9.1
• Other plugins installed: many listed in attached image. Issue occurred on installing and configuring Responsive Lightbox
• Theme: Shaped Pixels v 1.1.2 ( http://shapedpixels.com )
• Browser: On Mac, tested with current versions of Firefox, Chrome and Safari

Option to fix invalid registered sidebars

Since the code relies on properly registered sidebars with the class and id parameters set it might be a good idea to add an option to let this plugin try and fix the invalid ones.

If the before_widget and after_widget content isn't correct we can add a wrapper div with only this plugin's data.
Only add this as an option in the setting page, not by default.

Sort classes in frontend

Related: https://wordpress.org/support/topic/prepend-class-names-option/

Currently it's possible to sort the predefined classes in the settings page.

• Lets use the same order for the front end as well.
• Also add a hook for a custom sort by the user.

Compatibility with SiteOrigin Panels

Related topic: https://wordpress.org/support/topic/feature-request-add-support-for-siteorigin-panels/

Not sure whether this is something this plugin should do or if it's better that the SO Panels plugin adds compatibility with the dynamic_sidebar_params filter..

get_the_ID() throws a notice when no post is present

https://github.com/cleverness/widget-css-classes/blob/master/includes/widget-css-classes.class.php#L122

get_the_ID() throws a notice here when no post is present, i.e. on searches without a result.

Notice: Trying to get property of non-object in /…/wp-includes/post-template.php on line 29

Support (older) widgets

See #37

v1.5.4 prevents the warning but might be an idea to support these widgets as well.

Notice on empty 'classes'

Good morning!

PHP Notice: Undefined index: classes in /home/unlocked/website/html/static/plugins/widget-css-classes/includes/widget-css-classes.class.php on line 104

Could you check whether it is empty?
https://github.com/cleverness/widget-css-classes/blob/master/includes/widget-css-classes.class.php#L104

Copy translations to wp.org and remove files from plugin

These files aren't needed anymore.
We should copy it to translate.wordpress.org and remove the files once the translations are accepted.

Existing languages
Available on wp.org and removed in plugin are marked as complete
https://translate.wordpress.org/projects/wp-plugins/widget-css-classes

• nl_NL
• ru_RU
• es_ES
• pl_PL
• sk_SK
• sr_RS
• sv_SE

IE11 issue with predefined classes admin

Related: https://wordpress.org/support/topic/cant-highlight-and-copy-predefined-classes/

Non-custom widget classes are translated

Report: https://wordpress.org/support/topic/plugin-spanish-translation/#post-9427244

The first, last, odd, even and number widgets are translated which seems a little weird. Translations are normally for text only, not for code.
Since this plugin has 90k+ users we can't just remove it. I'd say make it an option so the users can turn it off/on.

On a fresh install: Don't enable it.
On an update with the classes enabled: Enable it to prevent issues.

Add hook for predefined classes based on the current theme

Related: #4
Related: https://wordpress.org/support/topic/can-i-register-several-classes-in-my-theme/

Readme updates

@cleverness
I'd like to hear your thoughts on the ideas below for the readme file.

• Plugin website > Move to GitHub Wiki or update website after each update. We can create a website link on the GitHub Wiki.
  • We can add documentation on the wiki as well, example: https://github.com/JoryHogeveen/view-admin-as/wiki
• Credits as a list item (more compact)
• Licence can be removed since there is a licence file within the plugin. All plugins on WP.org are GPL compatible.
• FAQ
  • Apply correct markup
  • Bug reporting: Change links to GitHub so contributors can help if possible.
  • Add numbers for FAQ questions