cloudflare/lua-aho-corasick

lua-aho-corasick's Issues

how get all patterns that match that given subject string

Hi,

I noticed that The Match_Tmpl not supports MV_ALL_MATCHES.

if (state->is_term) {
     if (variant == MV_FIRST_MATCH) {
         ac_result_t r;
         r.match_begin = idx - state->depth;
         r.match_end = idx - 1;
         r.pattern_idx = state->is_term - 1;
         return r;
     }

     if (variant == MV_LEFT_LONGEST) {
         int match_begin = idx - state->depth;
         int match_end = idx - 1;

         if (r.match_begin == -1 ||
             match_end - match_begin > r.match_end - r.match_begin) {
             r.match_begin = match_begin;
             r.match_end = match_end;
             r.pattern_idx = state->is_term - 1;
         }
         continue;
     }

     ASSERT(false && "NYI");
 }

What should I do if i want get all patterns that match that given subject
string? Why not implement variant == MV_ALL_MATCHES?

CFLAGS etc.

When I see things like -msse4.1 in ./Makefile, I wonder whether you intend the master branch of this repo for general-purpose usage, e.g. ending up in distribution packages. Should I make similar changes in a fork or shall we generalize it directly here, perhaps in a way that you might keep injecting such flags somehow?

Currently the binaries will end up in knot-resolver packages with these flags (even on ARM :) I suspect this will be a real problem for x86 systems without SSE 4.1, and most users surely won't notice a significant difference in speed if we drop these flags. (I understand you might notice the difference on CloudFlare servers.)

Similar projects

How does this compare to https://github.com/chatid/lua-ahocorasick ?

about load_ac.lua

when I use load_ac.lua in macos, sometimes it will report and generate core file
malloc: *** error for object 0x7f8bbc831400: incorrect checksum for freed object - object was probably modified after being freed

macos compile

it is not supported by macos, so I hope you it can be compatible for macos

FFI Example Usage

Hi,

Can you provide an example of using this via FFI (e.g. via libac.so)?

License?

License? Copyright headers? Is it cloudflare's original code or a copy of a third party library?