bug: allow using bind9-boshrelease without defining zones

[cloudfoundry-community]

bug: allow using bind9-boshrelease without defining zones

[jhunt]

That's an excellent use case, that I'd not previously thought of!

The issue probably stems from the fact that if you give bash a glob that doesn't match anything, it will give back the glob as the result: i.e. "echo *.enoent" will echo a literal *.enoent. In the context of a bash for loop, this is a valid token, so it loops once and the named-checkzone gets exec'd with a bad (non-existent) zone file.

I think this is as simple as a set -o nullglob, to skip the loop body altogether. I'm testing that locally in my lab right now.

[jhunt]

Yes, as I suspected:

[Thu Aug 13 15:25:02 UTC 2020] checking named configuration...
[Thu Aug 13 15:25:02 UTC 2020] named configuration OK

[Thu Aug 13 15:25:02 UTC 2020] checking zone '*' (in /var/vcap/sys/run/named/data/*.db)...
usage: named-checkzone [-djqvD] [-c class] [-f inputformat] [-F outputformat] [-J filename] [-t directory] [-w directory] [-k (ignore|warn|fail)] [-n (ignore|warn|fail)] [-m (ignore|warn|fail)] [-r (ignore|warn|fail)] [-i (full|full-sibling|local|local-sibling|none)] [-M (ignore|warn|fail)] [-S (ignore|warn|fail)] [-W (ignore|warn)] [-o filename] zonename filename

It's treating a literal * as the filename to check.

[jhunt]

Check out v1.3.0 which has this fix in it.

https://github.com/cloudfoundry-community/bind9-boshrelease/releases/tag/v1.3.0

[lrstanley]

Tested, and working. Thanks!